mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 08:00:42 +00:00
* feat(tradeskill): add GetTradeSkillRecipeLink and IsTradeSkillLinked GetTradeSkillRecipeLink(index) links the recipe in a trade-skill row as an enchant: link carrying the recipe's spell ID, in the form the client's own GetCraftItemLink (0x004F72A0) gives an enchanting formula (|cffffffff|Henchant:%d|h[%s]|h|r, format at 0x0084D410), with the spell's name in the client's locale. Rows are read as the engine's row functions read them, so a header row (spell ID -1) returns nothing. Vanilla's window only links the item a recipe makes. IsTradeSkillLinked() returns nil: on this client the trade-skill window and its functions only describe the player's own professions, since a received trade: link opens ClassicAPI's separate viewer. Zygor Guides Viewer 2.0 calls both on TRADE_SKILL_SHOW to record the recipes the player knows. Verified in-game (1.12.1 client via VanillaFixes, Zygor Guides Viewer 2.0): in the First Aid and Cooking windows, all 15 recipe rows link the row's own spell (checked against GetSpellInfo) and header rows return nothing; IsTradeSkillLinked() returns nil. * fix(tradeskill): match 3.3.5's GetTradeSkillRecipeLink and show its links GetTradeSkillRecipeLink now builds 3.3.5's link: gold, "Profession: Recipe" (the profession from the engine's SkillLineAbility lookup FUN_006de040, for the player's race and class), gated on SPELL_ATTR_TRADESPELL. Empty names are pushed as the record holds them, and the index is checked as a double before the cast, the way the engine truncates and compares unsigned. IsTradeSkillLinked returns (nil, nil), as 3.3.5 does. Both globals get doc descriptors. 1.12's SetHyperlink accepts enchant: only for records with +0x0C == 3, which no trade-skill recipe has, and raises "Unknown link type" for the rest. Tooltip::Hyperlink now shows the spell tooltip for a trade-spell enchant: link, as 3.3.5 does. That also fixes clicking SuperWoW's GetTradeSkillItemLink(index, 1) links; its SetHyperlink patch at 0x00532210 runs after this co-hook and handles only quest:. SPELL_ATTR_TRADESPELL moves to Offsets.h now that two files use it. --------- Co-authored-by: Brues <5278969+brues-code@users.noreply.github.com>