Files
ClassicAPI/docs
Brues d20a7febc4 fix(spell): resolve GetSpellInfo(name) through the engine
Spell::Lookup::SpellNameToID walked both spellbooks itself to answer
GetSpellInfo("name"): an exact strcmp on the locale name, a hand
split of "(Rank N)" that also allowed a space before the parenthesis,
and highest rank by last match. Every other name path here
(Spell::Arg, the C_Spell identifiers, the macro parser) already goes
through the engine's resolver, so the same name could resolve in
C_Spell.GetSpellInfo and fail in GetSpellInfo.

The engine's chain is FUN_RESOLVE_SPELL_NAME_TO_BOOK_ID (0x004B3BC0)
-> SplitSpellNameAndResolve (0x004B3950, splits at the last '(') ->
FindBookSpellSlot (0x004B3A10: player then pet book, from the last slot
down, SStrCmpI on name and rank). GetSpellInfo(name) now calls it
through Spell::Arg::NameToSpellID, and SpellNameToID is gone. Names
match case-insensitively, "Name (Rank N)" with a space no longer
matches (as with CastSpellByName), and the Spell::NameResolve forms
("!Name", a bare spellID) resolve too. API.md says so, and the
SpellIdentifier note no longer calls the C_Spell name lookup
case-sensitive.
2026-11-15 20:28:28 -06:00
..
2026-05-07 15:08:45 -05:00
2026-05-07 15:52:48 -05:00
2026-05-10 00:10:06 -05:00
2026-05-07 16:28:32 -05:00
2026-05-07 12:23:57 -05:00
2026-05-07 15:08:45 -05:00
2026-05-07 15:08:45 -05:00
2026-05-09 14:23:40 -05:00