Hi — heads-up about ShaguTweaks (the standalone addon in the launcher, not part of pfUI), which I'm using in the game and think is a great one.
While chasing an error in one of the addon's extensions (ShaguTweaks-mods), I found what looks like a genuine flaw in the core addon, and since its github repo is now archived, I dont't have enywhere else to turn except to whoever maintains the launcher I guess, as the launcher is distributing/offering ShaguTweaks in the addons tab.
The flaw:
ShaguTweaks loads all its modules in one loop with no error handling. If any single module throws an error while being initialised, the loop stops there and every module after it silently fails to load — so one broken module quietly takes down a bunch of unrelated features. This matters because other addons related to ShaguTweaks that are extending it and which are still being actively maintained (like Grylls' ShaguTweaks-Mods, etc.) can introduce bugs that bubble up and break the core. This exactly happened to me - an extension mod threw an error because of some frame that doesn't exist in the game's client and as a result a bunch of other unrelated features from ShaguTweaks then stopped working until I figured it out and fixed it for myself locally.
Because Shagu archived the repo (read-only since around the start of the year), this can't be patched upstream anymore — so anyone getting ShaguTweaks through the launcher is exposed to this permanently, for anything that any of those extensions do now or in future.
The fix I applied is very small though (wrap each module's load function in a protected call so one failure can't cascade. It changes nothing when everything works — it only stops a single broken module from taking the rest down with it, and prints a line naming the culprit instead).
In main.lua's module loop:
Before:
if mod.expansions[expansion] and ShaguTweaks_config[title] == 1 then
mod:enable()
end
After:
if mod.expansions[expansion] and ShaguTweaks_config[title] == 1 then
local ok, err = pcall(mod.enable, mod)
if not ok then
DEFAULT_CHAT_FRAME:AddMessage("|cffff5555ShaguTweaks:|r module '" .. tostring(title) .. "' failed: " .. tostring(err))
end
end
The addon now works for me great, as it used to, and I am once again a happy camper. I'd like for other ppl playing the game to also have the option to continue to have and use this addon in the future.
So my question is I guess:
Is there something that can be done so that the launcher carries a fixed/fully working version of the addon? (doesn't have to be this exact fix, just to somehow sort out the flaw, as I can't suggest it to the addon's original creator/maintainers anymore)
Happy to provide more info or help in some ways, thanks for maintaining the launcher/addon list.