OctoWoW/OctoLauncher
2
0
Fork 4
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Main #2

Closed
Dusk wants to merge 4 commits from Dusk/OctoLauncher:main into main
pull from: Dusk/OctoLauncher:main
merge into: OctoWoW:main
Conversation 9 Commits 4 Files Changed 2
+16 -16
Dusk commented 2026-06-16 12:57:19 +00:00
First-time contributor
Copy Link
Copy Source
No description provided.
octoadmin reviewed 2026-06-17 14:40:42 +00:00
octoadmin reviewed 2026-06-17 14:47:52 +00:00
server/src/addons-sources.ts Outdated
@@ -113,1 +111,3 @@
{ git: 'https://github.com/shagu/pfUI.git' },
{ git: 'https://github.com/The-Kludge-Bureau/pfQuest.git' },
{ git: 'https://github.com/KameleonUK/pfQuest-turtle.git' },
{ git: 'https://github.com/brues-code/pfUI.git' },
octoadmin commented 2026-06-17 14:47:52 +00:00
Owner
Copy Link
Copy Source

Having some trouble with pfUI on a fresh install using this new repo. If you revert this one change we can merge it in, or you can look into getting the dependencies needed for brues-code/pfUI.git included and wire up the dependencies in the launcher.

Having some trouble with pfUI on a fresh install using this new repo. If you revert this one change we can merge it in, or you can look into getting the dependencies needed for brues-code/pfUI.git included and wire up the dependencies in the launcher.
Dusk commented 2026-06-17 17:28:35 +00:00
Author
First-time contributor
Copy Link
Copy Source

pfQuest from Shagu actually performs better anyway
Reverted the pfUI change I'm not familiar with how to set up the required dependencies in the launcher

pfQuest from Shagu actually performs better anyway Reverted the pfUI change I'm not familiar with how to set up the required dependencies in the launcher
octoadmin marked this conversation as resolved
octoadmin requested changes 2026-06-17 14:50:59 +00:00
Dismissed
octoadmin left a comment
Owner
Copy Link
Copy Source

Just one small reversion for pfUI due to a ClassicAPI dependency then looks good to merge!

Just one small reversion for pfUI due to a ClassicAPI dependency then looks good to merge!
octoadmin approved these changes 2026-06-17 18:59:31 +00:00
Dusk commented 2026-06-18 11:59:32 +00:00
Author
First-time contributor
Copy Link
Copy Source

Hi, I think the build needs to be manually triggered. Thank you !

Hi, I think the build needs to be manually triggered. Thank you !
Dusk marked the pull request as work in progress 2026-06-19 14:22:20 +00:00
Dusk commented 2026-06-19 21:38:49 +00:00
Author
First-time contributor
Copy Link
Copy Source

Hi, you forgot to start the build

Hi, you forgot to start the build
octoadmin commented 2026-06-20 18:27:46 +00:00
Owner
Copy Link
Copy Source

Sorry we are waiting on some other internal changes to go in before we manually pull this into the server. We don't use the automated build paths on this gitea instance.

Sorry we are waiting on some other internal changes to go in before we manually pull this into the server. We don't use the automated build paths on this gitea instance.
👍 1 ❤️ 1
octoadmin marked the pull request as ready for review 2026-06-20 20:30:52 +00:00
octoadmin force-pushed main from 298e34bc04 to 1a0d960dca 2026-06-20 21:21:49 +00:00 Compare
octoadmin added 4 commits 2026-06-20 21:49:15 +00:00
Update server/src/addons-sources.ts a9b8cc5ba5
Update src/common/mods.ts 8d4e447ee7
Update server/src/addons-sources.ts
Build check / build (pull_request) Has been cancelled
Details
a11062a575
Update server/src/addons-sources.ts
Build check / build (pull_request) Has been cancelled
Details
298e34bc04
octoadmin force-pushed main from 1a0d960dca to 298e34bc04 2026-06-20 21:49:15 +00:00 Compare
octoadmin commented 2026-06-20 22:24:54 +00:00
Owner
Copy Link
Copy Source

Instead of just merging yours in then handling our changes, I did ours first causing some conflicts here. Decided to just open a new PR with your changes though so closing this one out. #4

Instead of just merging yours in then handling our changes, I did ours first causing some conflicts here. Decided to just open a new PR with your changes though so closing this one out. https://octowow.st/git/OctoWoW/OctoLauncher/pulls/4
octoadmin closed this pull request 2026-06-20 22:26:19 +00:00
Dusk commented 2026-06-29 08:22:59 +00:00
Author
First-time contributor
Copy Link
Copy Source

Hi, why revert back to the old addon links? Most of them are dead or obsolete now

Hi, why revert back to the old addon links? Most of them are dead or obsolete now
Some checks are pending
Build check / build (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
octoadmin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
octoadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OctoWoW/OctoLauncher#2
Delete Branch "Dusk/OctoLauncher:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?