OctoWoW/OctoLauncher
2
0
Fork 4
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Turkish translation addons have been added to the addon sources #6

Closed
ftdeveloperacc wants to merge 2 commits from ftdeveloperacc/OctoLauncher:feature/TurkishTranslationAddons into main
pull from: ftdeveloperacc/OctoLauncher:feature/TurkishTranslationAddons
merge into: OctoWoW:main
Conversation 4 Commits 2 Files Changed 1
+13 -1
ftdeveloperacc commented 2026-06-26 07:12:38 +00:00
First-time contributor
Copy Link
Copy Source
No description provided.
ftdeveloperacc added 1 commit 2026-06-26 07:12:38 +00:00
Turkish translation addons have been added to the addon sources
Build check / build (pull_request) Has been cancelled
Details
11f5b0d914
octoadmin requested changes 2026-06-29 02:12:01 +00:00
Dismissed
octoadmin left a comment
Owner
Copy Link
Copy Source

Unfortunately we will need to you refactor this so it only shows the actual diffs in this file. Looks like an issue of CRLF to LF conversion causing it. Please re-commit with CRLF when you can.

Unfortunately we will need to you refactor this so it only shows the actual diffs in this file. Looks like an issue of CRLF to LF conversion causing it. Please re-commit with CRLF when you can.
ftdeveloperacc added 1 commit 2026-06-29 12:26:30 +00:00
Line ending changed to CRLF
Build check / build (pull_request) Has been cancelled
Details
bbaf16ec64
octoadmin requested changes 2026-06-29 17:07:10 +00:00
octoadmin left a comment
Owner
Copy Link
Copy Source

I believe that the function of these addon's is no longer needed after the most recent localization changes to the launcher/game. Can you confirm?

I believe that the function of these addon's is no longer needed after the most recent localization changes to the launcher/game. Can you confirm?
ftdeveloperacc commented 2026-06-29 17:55:22 +00:00
Author
First-time contributor
Copy Link
Copy Source

I believe that the function of these addon's is no longer needed after the most recent localization changes to the launcher/game. Can you confirm?

These in-game add-ons translate elements like quests, mobs, and zones to assist non-native English speakers (specifically for Turkish). They operate completely independently of the launcher.

> I believe that the function of these addon's is no longer needed after the most recent localization changes to the launcher/game. Can you confirm? These in-game add-ons translate elements like quests, mobs, and zones to assist non-native English speakers (specifically for Turkish). They operate completely independently of the launcher.
octoadmin commented 2026-06-30 03:10:21 +00:00
Owner
Copy Link
Copy Source

Yes, there were localization changes to the launcher and the server to translate (hopefully) everything. Can you please go try them out and confirm that they work and these addons are no longer needed?

Yes, there were localization changes to the launcher and the server to translate (hopefully) everything. Can you please go try them out and confirm that they work and these addons are no longer needed?
ftdeveloperacc closed this pull request 2026-06-30 06:42:09 +00:00
Some checks are pending
1 workflow awaiting approval

The workflow will only run after approval from the repository maintainer.

Build check / build (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
octoadmin
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
octoadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OctoWoW/OctoLauncher#6
Delete Branch "ftdeveloperacc/OctoLauncher:feature/TurkishTranslationAddons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?