brues/SuperCleveRoidMacros
1
1
Fork 0
mirror of https://github.com/brues-code/SuperCleveRoidMacros.git synced 2026-09-16 03:38:00 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

Merge pull request #36 from jrc13245/claude/improve-combodurations-01GHh5y6dXtxNhoizDK8bSw3

Browse Source 
Fix pfUI AddEffect timing - use name-based tracking instead of ID
This commit is contained in:
Torio
2025-11-16 13:43:23 -05:00
committed by GitHub
parent e814a3f8de c9bd224c2b
commit 3c98627e5a
1 changed files with 10 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Compatibility/pfUI.lua
+10 -21
View File
@@ -152,27 +152,16 @@ function Extension.HookPfUILibdebuff()
-- effect is a spell name, not ID
-- Check if this is a combo scaling spell by name
if CleveRoids.IsComboScalingSpell and CleveRoids.IsComboScalingSpell(effect) then
-- Try to get learned duration for this combo spell
local spellData = CleveRoids.GetComboScalingData(effect)
if spellData then
-- Find the spell ID for this effect
for spellID, data in pairs(CleveRoids.ComboScalingSpellsByID) do
if data.name == effect then
-- Check if we have tracking data
if CleveRoids.ComboPointTracking and CleveRoids.ComboPointTracking.byID and
CleveRoids.ComboPointTracking.byID[spellID] then
local tracking = CleveRoids.ComboPointTracking.byID[spellID]
if tracking.duration then
duration = tracking.duration
if CleveRoids.debug then
DEFAULT_CHAT_FRAME:AddMessage(
string.format("|cff00ff00[pfUI AddEffect Hook]|r Overriding %s duration to %ds",
effect, duration)
)
end
break
end
end
-- Use name-based tracking which is populated BEFORE pfUI's AddEffect
if CleveRoids.ComboPointTracking and CleveRoids.ComboPointTracking[effect] then
local tracking = CleveRoids.ComboPointTracking[effect]
if tracking.duration and (GetTime() - tracking.cast_time) < 0.5 then
duration = tracking.duration
if CleveRoids.debug then
DEFAULT_CHAT_FRAME:AddMessage(
string.format("|cff00ff00[pfUI AddEffect Hook]|r Overriding %s duration to %ds (from name tracking)",
effect, duration)
)
end
end
end