Delete the Lua paladin judgement refresh

A paladin's white swing refreshes their own judgement debuff on the victim, and
the server's edit is packet-silent, so pfUI#45 was the visible symptom: the
timer ran to zero while the debuff stayed up. This addon worked around it three
ways at once -- a UNIT_CASTEVENT MAINHAND/OFFHAND handler in Core.lua, an
AUTO_ATTACK_OTHER fallback in Conditionals.lua, and a CHAT_MSG_COMBAT_SELF_HITS
parser in Utility.lua that string-matched "hit"/"crit" and guessed at melee vs
spell by looking for a parenthesis -- each rewriting rec.start and pushing the
result into pfUI by hand.

ClassicAPI mirrors the server rule in the DLL (src/aura/JudgementRefresh.cpp),
keyed off SMSG_ATTACKERSTATEUPDATE, which is the visible trigger for the
invisible edit. It matches judgements by their DBC marker -- SPELLFAMILY_PALADIN
with SPELL_ATTR_EX3_ALWAYS_HIT -- for any paladin's judgements, not only ours.

That last detail retires the auto-detection too. The hardcoded judgementSpells
list could not cover Turtle's custom judgement ranks, so a cast queued a pending
scan that read the target's debuffs 0.5s later, matched names against
"^Judgement", and grew the list at runtime. Matching on the DBC attribute needs
no list to grow. Gone with it: judgementSpells, pendingJudgements,
detectedJudgementDebuffIDs, the pending-scan pass and its queue buffer, and both
cast-site hooks.

The scan also registered each ID it discovered into lib.sharedDebuffs so
[debuff] fallback matching worked for custom IDs. That mattered when detection
went through the tracking store; the read path resolves auras through
C_UnitAuras now, which returns a debuff whether or not we have a row for it.

ComboPointTracker.lua

@@ -15,23 +15,6 @@ CleveRoids.ComboPointTracking = CleveRoids.ComboPointTracking or {}
 -- Structure: CleveRoids_ComboDurations[spellID][comboPoints] = duration
 CleveRoids_ComboDurations = CleveRoids_ComboDurations or {}
 
--- Storage for last Rip cast (for Carnage talent mechanic)
--- Carnage talent: When Ferocious Bite procs Carnage, it refreshes Rip and Rake to their original duration
--- Detection: When combo points don't drop to 0 after FB (they stay at 1 = Carnage proc)
--- Talent Position: Tab 2 (Feral Combat), Talent 17
--- Rank 1: 10% per CP, Rank 2: 20% per CP
-CleveRoids.lastRipCast = CleveRoids.lastRipCast or {
-    duration = nil,
-    targetGUID = nil,
-    timestamp = 0
-}
-
-CleveRoids.lastRakeCast = CleveRoids.lastRakeCast or {
-    duration = nil,
-    targetGUID = nil,
-    timestamp = 0
-}
-
 -- Family membership without hardcoded rank lists. C_Spell.GetSpellName resolves
 -- ANY spellID from the client's Spell.dbc -- every rank (so no enumeration or
 -- spellbook scan) and TWoW's custom spells alike -- so "is this spellID a Rip?"
@@ -86,10 +69,8 @@ CleveRoids.ComboScalingSpellsByID = {
     [9896] = { base = 10, increment = 2, name = "Rip" },           -- Rank 6
 }
 
--- Ferocious Bite spell IDs (for Carnage talent mechanic)
--- Carnage talent: When FB procs Carnage, refreshes Rip and Rake back to their original duration
--- Proc detection: combo points stay at 1 after FB instead of dropping to 0
--- Talent Position: Tab 2 (Feral Combat), Talent 17
+-- Ferocious Bite spell IDs. A combo-point finisher, so the cast-time combo
+-- snapshot has to know it.
 CleveRoids.FerociousBiteSpellIDs = {
     [22557] = true,  -- Rank 1
     [22568] = true,  -- Rank 2
@@ -99,10 +80,6 @@ CleveRoids.FerociousBiteSpellIDs = {
     [31018] = true,  -- Rank 6
 }
 
--- Rip / Rake families (for Carnage talent). Seeded by Rank 1; matches every rank.
-CleveRoids.RipSpellIDs = RankSet(1079)
-CleveRoids.RakeSpellIDs = RankSet(1822)
-
 -- Combined table for all bleed spells that need immunity detection
 -- Used when checking if a cast bleed failed to apply (indicates bleed immunity)
 -- NOTE: These are the DEBUFF spell IDs (what appears on target), not cast spell IDs
@@ -168,14 +145,6 @@ CleveRoids.ImmolateSpellIDs = {
     [25309] = true,  -- Rank 8
 }
 
--- =============================================================================
--- WARLOCK: Dark Harvest Duration Acceleration (TWoW Custom)
--- Channeled spell that accelerates DoT tick rate by 30% while channeling
--- Complex tracking: debuff expires 30% faster while Dark Harvest is active
--- =============================================================================
--- TWoW custom (see MoltenBlast note).
-CleveRoids.DarkHarvestSpellIDs = RankSet(52550)
-
 -- =============================================================================
 -- DRUID: Rake Debuff Cap Boss Whitelist
 -- These bosses are likely to hit the 48 debuff cap, causing Rake to get pushed off
@@ -773,55 +742,6 @@ end
 
 function Extension.OnComboPointsChanged()
     CleveRoids.UpdateComboPoints()
-
-    -- CARNAGE PROC DETECTION (Cursive-style)
-    -- When Ferocious Bite is used, combo points should drop to 0
-    -- If Carnage procs, combo points will be 1 instead (the Carnage-granted combo point)
-    -- Check: After Ferocious Bite (within 0.5s), if combo points > 0, Carnage procced
-    if CleveRoids.lastFerociousBiteTime and CleveRoids.lastFerociousBiteTargetGUID then
-        local timeSinceBite = GetTime() - CleveRoids.lastFerociousBiteTime
-        if timeSinceBite < 0.5 then
-            local currentCP = CleveRoids.GetComboPoints()
-            if currentCP > 0 then
-                -- Carnage procced! Combo points didn't drop to 0 (or rose back to 1)
-                if CleveRoids.debug then
-                    DEFAULT_CHAT_FRAME:AddMessage(
-                        string.format("|cffff00ff[Carnage]|r PROC DETECTED! CP=%d after Ferocious Bite (%.2fs ago)",
-                            currentCP, timeSinceBite)
-                    )
-                end
-
-                -- Apply the Carnage refresh to Rip and Rake
-                local targetGUID = CleveRoids.lastFerociousBiteTargetGUID
-                local targetName = CleveRoids.lastFerociousBiteTargetName or "Unknown"
-                local biteSpellID = CleveRoids.lastFerociousBiteSpellID
-
-                -- Call the Carnage refresh function in Utility.lua
-                if CleveRoids.libdebuff and CleveRoids.libdebuff.ApplyCarnageRefresh then
-                    CleveRoids.libdebuff.ApplyCarnageRefresh(targetGUID, targetName, biteSpellID)
-                end
-
-                -- Clear the tracking to prevent multiple refreshes
-                CleveRoids.lastFerociousBiteTime = nil
-                CleveRoids.lastFerociousBiteTargetGUID = nil
-                CleveRoids.lastFerociousBiteTargetName = nil
-                CleveRoids.lastFerociousBiteSpellID = nil
-            end
-        else
-            -- Time window expired, clear tracking
-            if CleveRoids.lastFerociousBiteTime then
-                if CleveRoids.debug then
-                    DEFAULT_CHAT_FRAME:AddMessage(
-                        string.format("|cffff00ff[Carnage]|r No proc - time window expired (%.2fs)", timeSinceBite)
-                    )
-                end
-                CleveRoids.lastFerociousBiteTime = nil
-                CleveRoids.lastFerociousBiteTargetGUID = nil
-                CleveRoids.lastFerociousBiteTargetName = nil
-                CleveRoids.lastFerociousBiteSpellID = nil
-            end
-        end
-    end
 end
 
 -- Event handlers

Conditionals.lua

@@ -897,43 +897,6 @@ local function OnAutoAttackOther(attackerGuid, targetGuid, totalDamage, hitInfo,
     CleveRoids.LastSwing.resistAmount = totalResist or 0
     CleveRoids.LastSwing.targetGuid = targetGuid
 
-    -- Paladin: refresh active Judgements on melee hit (Nampower fallback for UNIT_CASTEVENT)
-    if CleveRoids.playerClass == "PALADIN" and targetGuid then
-        local lib = type(CleveRoids.libdebuff) == "table" and CleveRoids.libdebuff or nil
-        if lib and lib.objects then
-            local normalizedTarget = CleveRoids.NormalizeGUID(targetGuid)
-            if normalizedTarget and lib.objects[normalizedTarget] then
-                for spellID, rec in pairs(lib.objects[normalizedTarget]) do
-                    if lib.judgementSpells and lib.judgementSpells[spellID] and rec.start and rec.duration then
-                        local remaining = rec.duration + rec.start - GetTime()
-                        if remaining > 0 and rec.caster == "player" then
-                            rec.start = GetTime()
-
-                            if CleveRoids.debug then
-                                local spellName = C_Spell.GetSpellName(spellID) or "Unknown"
-                                local baseName = CleveRoids.StripRank(spellName) or "Unknown"
-                                DEFAULT_CHAT_FRAME:AddMessage(
-                                    string.format("|cff00ffaa[Judgement Refresh]|r Refreshed %s (ID:%d) on melee hit - new duration: %ds",
-                                        baseName, spellID, rec.duration)
-                                )
-                            end
-
-                            -- Sync to pfUI if loaded (pre-7.6 only)
-                            if pfUI and pfUI.api and pfUI.api.libdebuff then
-                                local spellName = C_Spell.GetSpellName(spellID) or nil
-                                local baseName = CleveRoids.StripRank(spellName)
-                                local targetName = (lib.guidToName and lib.guidToName[normalizedTarget]) or UnitName("target")
-                                local targetLevel = UnitLevel("target") or 0
-                                if targetName and baseName then
-                                    pfUI.api.libdebuff:AddEffect(targetName, targetLevel, baseName, rec.duration, "player")
-                                end
-                            end
-                        end
-                    end
-                end
-            end
-        end
-    end
 end
 
 -- Process AUTO_ATTACK_SELF event (player being attacked)

Core.lua

@@ -4260,20 +4260,6 @@ function CleveRoids.OnUpdate(self)
     if (time - CR.lastCleanupTime) >= CR.CLEANUP_INTERVAL then
         CR.lastCleanupTime = time
 
-        -- MEMORY: Clean up carnageDurationOverrides older than 30 seconds
-        -- PERFORMANCE: Use next() directly instead of pairs() to avoid iterator allocation
-        local carnageOverrides = CR.carnageDurationOverrides
-        if carnageOverrides then
-            local spellID, data = next(carnageOverrides)
-            while spellID do
-                local nextID = next(carnageOverrides, spellID)
-                if data.timestamp and (time - data.timestamp) > 30 then
-                    carnageOverrides[spellID] = nil
-                end
-                spellID, data = nextID, nextID and carnageOverrides[nextID]
-            end
-        end
-
         -- MEMORY: Clean up old ComboPointTracking entries (older than 60 seconds)
         -- PERFORMANCE: Use next() directly instead of pairs() to avoid iterator allocation
         local comboTracking = CR.ComboPointTracking
@@ -4630,58 +4616,11 @@ function CleveRoids.Frame:ADDON_LOADED(addon)
 end
 
 function CleveRoids.Frame:UNIT_CASTEVENT(caster,target,action,spell_id,cast_time)
-    -- Handle melee swings for judgement refresh
+    -- Melee swings carry no spell to resolve. ClassicAPI mirrors the server's
+    -- paladin judgement-refresh rule off SMSG_ATTACKERSTATEUPDATE in the DLL
+    -- (src/aura/JudgementRefresh.cpp), so there is nothing to do here.
     if action == "MAINHAND" or action == "OFFHAND" then
-        -- Only process if this is the player's melee swing
-        if caster == CleveRoids.playerGuid and CleveRoids.playerClass == "PALADIN" then
-            -- Refresh judgements on the target
-            -- Defensive: verify libdebuff is a table before accessing properties
-            local lib = type(CleveRoids.libdebuff) == "table" and CleveRoids.libdebuff or nil
-            if target and lib and lib.objects then
-                local normalizedTarget = CleveRoids.NormalizeGUID(target)
-                if normalizedTarget and lib.objects[normalizedTarget] then
-                    -- Refresh all active Judgements on the target
-                    for spellID, rec in pairs(lib.objects[normalizedTarget]) do
-                        -- Check if this is a judgement by spell ID
-                        if lib.judgementSpells and lib.judgementSpells[spellID] and rec.start and rec.duration then
-                            -- Only refresh if the Judgement is still active and was cast by player
-                            local remaining = rec.duration + rec.start - GetTime()
-                            if remaining > 0 and rec.caster == "player" then
-                                -- Refresh the Judgement by updating the start time
-                                rec.start = GetTime()
-
-                                local spellName = C_Spell.GetSpellName(spellID)
-                                local baseName = CleveRoids.StripRank(spellName) or "Unknown"
-
-                                if CleveRoids.debug then
-                                    DEFAULT_CHAT_FRAME:AddMessage(
-                                        string.format("|cff00ffaa[Judgement Refresh]|r Refreshed %s (ID:%d) on %s hit - new duration: %ds",
-                                            baseName, spellID, action, rec.duration)
-                                    )
-                                end
-
-                                -- Also sync to pfUI if it's loaded (pre-7.6 only)
-                                if pfUI and pfUI.api and pfUI.api.libdebuff then
-                                    local targetName = (lib.guidToName and lib.guidToName[normalizedTarget]) or UnitName("target")
-                                    local targetLevel = UnitLevel("target") or 0
-
-                                    if targetName then
-                                        pfUI.api.libdebuff:AddEffect(targetName, targetLevel, baseName, rec.duration, "player")
-
-                                        if CleveRoids.debug then
-                                            DEFAULT_CHAT_FRAME:AddMessage(
-                                                string.format("|cff00ffaa[pfUI Judgement Refresh]|r Synced %s refresh to pfUI", baseName)
-                                            )
-                                        end
-                                    end
-                                end
-                            end
-                        end
-                    end
-                end
-            end
-        end
-        return  -- Still return early after processing melee
+        return
     end
 
     -- Debug channel tracking
@@ -5075,26 +5014,6 @@ function CleveRoids.Frame:SPELLCAST_CHANNEL_STOP()
     CleveRoids.CurrentSpell.spellName = ""
     CleveRoids.CurrentSpell.castingSpellId = nil
 
-    -- WARLOCK DARK HARVEST: Mark channeling as ended
-    -- Credits: Avitasia / Cursive addon
-    if CleveRoids.darkHarvestData and CleveRoids.darkHarvestData.isActive then
-        CleveRoids.darkHarvestData.isActive = false
-        CleveRoids.darkHarvestData.endTime = GetTime()
-
-        -- Apply Dark Harvest end to all DoTs on target (finalizes reduction)
-        if CleveRoids.libdebuff and CleveRoids.libdebuff.ApplyDarkHarvestEnd then
-            CleveRoids.libdebuff.ApplyDarkHarvestEnd(CleveRoids.darkHarvestData.targetGUID)
-        end
-
-        if CleveRoids.debug then
-            local activeTime = CleveRoids.darkHarvestData.endTime - CleveRoids.darkHarvestData.startTime
-            DEFAULT_CHAT_FRAME:AddMessage(
-                string.format("|cff9482c9[Dark Harvest]|r Channel ended after %.1fs (DoT acceleration stopped)",
-                    activeTime)
-            )
-        end
-    end
-
     -- Force immediate action update
     CleveRoids.TestForAllActiveActions()
 end