phase 2 removing tbc

Strip dead pfUI.client > 11200 and pfUI.expansion == "tbc" branches now
that vanilla is the only supported client.

- pfUI.lua: hardcode expansion = "vanilla"; collapse force_region matrix
- compat/vanilla.lua, libs/{libcast,libdebuff,libtotem,libunitscan,
  focus}: drop always-false early-returns
- api/unitframes.lua: delete TargetBuffOnUpdate poller + tbc visibility
  and secure-template branches; click-cast keeps only vanilla path
- api/ui-widgets.lua: unconditional EffectiveScale divide
- env/tables.lua: drop unused focus/focustarget pfValidUnits entries
- modules/actionbar.lua: simplify EnablePaging, drop ButtonSwitch/
  petvisibility, unwrap prowl block, single keybind-remap path
- modules/{castbar,chat,cooldown,loot,questitem,totems}: unwrap
  always-true conditionals
- modules/nameplates.lua: cfg-only fake-cooldown gate, unwrap overlap/
  clickthrough + mouselook blocks
- modules/friends.lua + skins/blizzard/friends.lua: maxtab = 4
- skins/blizzard/{help,game_menu,questlog}: drop tbc-only branches

skins/blizzard/friends.lua

@@ -1,7 +1,7 @@
 pfUI:RegisterSkin("Friends", "vanilla:tbc", function ()
   local rawborder, border = GetBorderSize()
   local bpad = rawborder > 1 and border - GetPerfectPixel() or GetPerfectPixel()
-  local maxtab = pfUI.expansion == "vanilla" and 4 or 5
+  local maxtab = 4
 
   StripTextures(FriendsFrame, true)
   CreateBackdrop(FriendsFrame, nil, nil, .75)

skins/blizzard/game_menu.lua

@@ -4,11 +4,7 @@ pfUI:RegisterSkin("Game Menu", "vanilla:tbc", function ()
   CreateBackdropShadow(GameMenuFrame)
 
   GameMenuFrame:SetWidth(GameMenuFrame:GetWidth() - 30)
-  if pfUI.expansion == 'tbc' then
-    GameMenuFrame:SetHeight(GameMenuFrame:GetHeight() + 10)
-  elseif pfUI.expansion == 'vanilla' then
-    GameMenuFrame:SetHeight(GameMenuFrame:GetHeight() + 6)
-  end
+  GameMenuFrame:SetHeight(GameMenuFrame:GetHeight() + 6)
 
   local title = GetNoNameObject(GameMenuFrame, "FontString", "ARTWORK", MAIN_MENU)
   title:SetTextColor(1,1,1,1)

skins/blizzard/help.lua

@@ -2,18 +2,6 @@ pfUI:RegisterSkin("Help", "vanilla:tbc", function ()
   local rawborder, border = GetBorderSize()
   local bpad = rawborder > 1 and border - GetPerfectPixel() or GetPerfectPixel()
 
-  -- not much here for tbc yet
-  if pfUI.client > 11200 then
-    local ticket, background = TicketStatusFrame:GetChildren()
-    CreateBackdrop(background, nil, true, .75)
-    TicketStatusFrame:SetHeight(40)
-    TicketStatusFrame:ClearAllPoints()
-    TicketStatusFrame:SetPoint("TOP", 0, -5)
-
-    UpdateMovable(TicketStatusFrame)
-    return
-  end
-
   StripTextures(HelpFrame)
   CreateBackdrop(HelpFrame, nil, nil, .75)
   CreateBackdropShadow(HelpFrame)

skins/blizzard/questlog.lua

@@ -180,11 +180,7 @@ pfUI:RegisterSkin("Quest Log", "vanilla:tbc", function ()
         if C.questlog.showQuestLevels == "1" then
           questIndex = i + FauxScrollFrame_GetOffset(QuestLogListScrollFrame)
           if questIndex <= numEntries then
-            if pfUI.expansion == 'vanilla' then
-              text, level, questTag, isHeader = GetQuestLogTitle(questIndex)
-            else
-              text, level, questTag, _, isHeader = GetQuestLogTitle(questIndex)
-            end
+            text, level, questTag, isHeader = GetQuestLogTitle(questIndex)
             if not isHeader then
               _G["QuestLogTitle"..i]:SetText(" ".."["..(questTag and level.."+" or level).."] "..text)
             end