brues/pfUI
1
1
Fork 0
mirror of https://github.com/brues-code/pfUI.git synced 2026-09-27 01:46:03 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

Revert "this should fix no-target mobs casting with the same name"

Browse Source 
This reverts commit 35ec17d9a0.
This commit is contained in:
Meow
2026-03-22 17:07:52 +01:00
parent 35ec17d9a0
commit cd4a3343cb
1 changed files with 42 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/nameplates.lua
+42 -20
View File
@@ -1513,20 +1513,25 @@ nameplates:RegisterEvent("ZONE_CHANGED_NEW_AREA")
-- Use multiple checks for target detection (target variable, istarget flag, or zoomed state)
local isTargetPlate = target or nameplate.istarget or (nameplate.health and nameplate.health.zoomed)
if cfg.showcastbar and ( not cfg.targetcastbar or isTargetPlate ) then
-- Always use GUID for cast lookup to prevent duplicate castbars on same-name mobs
local plateGUID = nil
local unitstr = nil
local targetGUID = nil
-- Get GUID for CastEvents lookup - use cached GUID when available
if isTargetPlate then
plateGUID = state and state.targetGuid
if not plateGUID then
plateGUID = GetUnitGUID("target")
targetGUID = state and state.targetGuid
if not targetGUID then
local guid = GetUnitGUID("target")
targetGUID = guid
end
else
plateGUID = nameplate.cachedGuid
end
-- Check event-based cast cache by GUID
local castInfo = plateGUID and GetCastInfo(plateGUID)
-- Use cached GUID for non-target plates
if not isTargetPlate then
unitstr = nameplate.cachedGuid
end
-- Check event-based cast cache first (use GUID)
local castInfo = GetCastInfo(targetGUID) or (unitstr and GetCastInfo(unitstr))
if castInfo and castInfo.spellID then
-- Check if cast is still valid
@@ -1570,21 +1575,38 @@ nameplates:RegisterEvent("ZONE_CHANGED_NEW_AREA")
nameplate.castbar:Show()
end
else
-- No cast in libdebuff_casts for this GUID
-- For target plate: try API fallback (channels may not be in cast cache)
-- For non-target: no GUID = no castbar (prevents duplicate castbars on same-name mobs)
-- Fallback to API calls only when no GUID available (Nampower not tracking this unit)
local channel, cast, nameSubtext, text, texture, startTime, endTime, isTradeSkill
if isTargetPlate and UnitExists("target") then
if UnitCastingInfo then
if targetGUID then
-- We have a GUID but Nampower has no cast info.
-- Fall back to API for the target plate (channels may not be in cast cache)
if isTargetPlate and UnitExists("target") then
cast, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitCastingInfo("target")
if not cast then
channel, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitChannelInfo("target")
end
end
if not cast and UnitChannelInfo then
if not cast and not channel then
nameplate.castbar:Hide()
end
elseif isTargetPlate and UnitExists("target") then
cast, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitCastingInfo("target")
if not cast then
channel, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitChannelInfo("target")
end
elseif plateGUID then
-- Non-target with GUID but no cast data = no cast
nameplate.castbar:Hide()
elseif unitstr then
local guid = GetUnitGUID(unitstr)
local q = guid or unitstr
cast, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitCastingInfo(q)
if not cast then
channel, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitChannelInfo(q)
end
elseif name then
cast, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitCastingInfo(name)
if not cast then
channel, nameSubtext, text, texture, startTime, endTime, isTradeSkill = UnitChannelInfo(name)
end
end
if not cast and not channel then