String literals in benilla-assets, -blp, -protocol and -srp carry no record numbers (#291)

Part of #92, for the crates whose comment pass has landed and whose literals are few: `benilla-assets`, `benilla-blp`, `benilla-protocol` and `benilla-srp`.

- Assert messages, printed labels and a probe's error text drop their private record and bug numbers and the workspace's name for the maintainer. Each keeps its fact in its own words. One assert names a client function by its address, `0x68a830`, instead of a disassembler's label for it.
- Two terrain tests named after a bug number are renamed for what they check: `the_pin_stands_one_chunk_west_of_an_impassable_band` in `benilla-formats`, and `a_body_walking_east_from_the_pin_is_stopped_at_the_wall` in `benilla-world`. Those two crates' other literals follow in their own pass.
- Every change is to string-literal text, proven with comments stripped and every literal masked, except the two renamed tests.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Sam Sung
2026-09-25 16:17:21 +07:00
committed by GitHub
co-authored by Claude Opus 5.5
parent c04d74f47c
commit 715d6d91c9
8 changed files with 13 additions and 13 deletions
@@ -33,8 +33,8 @@ enum Arm {
impl Arm {
fn label(self) -> &'static str {
match self {
Arm::Zeros => "zeros (pre-1263)",
Arm::Computed => "computed (1263) ",
Arm::Zeros => "zeros ",
Arm::Computed => "computed",
}
}
}
@@ -178,7 +178,7 @@ impl Probe for QuestItem {
)?;
anyhow::ensure!(
refusal == "13",
"--quest-item: expected QUEST_INVALID reason 13 (ALREADY_ON, the director's 0x0d), \
"--quest-item: expected QUEST_INVALID reason 13 (ALREADY_ON, 0x0d), \
got {refusal}"
);
println!("✅ refusal: QUEST_INVALID reason 13 → ERR_QUEST_ALREADY_ON (the ref's 0x5dbca0)");
@@ -308,7 +308,7 @@ fn player_bytes_3_byte_3_is_the_current_pvp_rank_not_the_highest() {
assert_eq!(
f.player_honor_rank(),
None,
"the HIGHEST rank is a different field (1222) — absent means absent"
"the HIGHEST rank is a different field: absent means absent"
);
// A demoted player keeps the higher lifetime rank.
let demoted = ObjectFields::from_pairs(&[(195, 0x03_00_00_00), (1222, 0x0B_00_00_00)]);