upstream: finish the picked commits' build — drop WorldWriter::sent, add set_enemy_plates

crates/benilla-app/src/capture/fixtures.rs

@@ -1485,6 +1485,18 @@ pub(super) fn seed_ui_fixture(
     }
 }
 
+/// Turn the enemy nameplates on or off through the stock `NAMEPLATES_ON` global.
+fn set_enemy_plates(script: Option<&benilla_ui::script::UiScript>, on: bool) {
+    let lua = if on {
+        "NAMEPLATES_ON = 1; ShowNameplates()"
+    } else {
+        "NAMEPLATES_ON = nil; HideNameplates()"
+    };
+    if let Some(Err(e)) = script.map(|s| s.run(lua)) {
+        warn!("nameplates: {e}");
+    }
+}
+
 /// The `GetTime()` the cooldown filmstrip pins the VM's session clock at, seconds. Large, as
 /// `CooldownFrame_SetTimer` ignores a start not above 0 (`Cooldown.lua:2`) and the starts here
 /// are `now - fraction * span`.

crates/benilla-protocol/src/world/writer/mod.rs

@@ -60,9 +60,6 @@ mod vendor;
 pub struct WorldWriter {
     pub(super) stream: TcpStream,
     pub(super) encrypter: EncrypterHalf,
-    /// Every packet that reached the socket since the last drain, as `(opcode, body length)`;
-    /// `None` until [`Self::watch_sends`]. Pushed only after a successful write.
-    pub(super) sent: Option<Vec<(u16, usize)>>,
     /// The character's faction language, set at login from its race, which a chat send naming no
     /// language carries. vmangos drops the whole message, dot-commands included, when the
     /// character does not know the language.