grom/benilla-octo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ui: teach the producer gates the reach-reporting fire

Browse Source 
`every_event_a_chain_file_registers_has_a_producer` finds producers by
scanning our own `.rs` for `fire_event(`, `fire_event_into(` and
`pending_events.push((` followed by a string literal. `49b4f7b5` moved
`area.rs`'s minimap fire to `fire_event_reach(`, which matches none of
them, so the gate began reporting that `Minimap.xml` listens for
`MINIMAP_ZONE_CHANGED` and nothing fires it. Both scanners here now
match that spelling too.

The break rode green through a full gate run and a commit because this
test and its sibling need `WOW_DATA`, which `scripts/gates.sh` does not
set — on a machine without the client data 1609 tests skip silently.
Found by running `WOW_DATA=<Data> cargo test -p benilla-app --lib` and
diffing the failures against a baseline at HEAD: 3 before, 2 after, and
the two that remain fail at HEAD as well.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn
This commit is contained in:
grom
2026-10-23 15:05:50 -06:00
co-authored by Claude Opus 5
parent d3d2103919
commit ef7f823d9a
1 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/benilla-app/src/ui_script/reference_ui.rs
+21 -13
View File
@@ -1973,8 +1973,12 @@ mod tests {
// with the whitespace before each `.` removed.
let text = glue_chains(&text);
// The engine's deferred lane, `pending_events.push((name, args))`, fires too.
const CALLS: [&str; 3] = [
const CALLS: [&str; 4] = [
concat!("fire_event", "("),
// The reach-reporting sibling fires exactly as `fire_event` does; left out
// of this list it silently stops counting as a producer, which is how
// `MINIMAP_ZONE_CHANGED` came to read as unfired after `49b4f7b5`.
concat!("fire_event_reach", "("),
concat!("fire_event_into", "("),
concat!("pending_events.push", "(("),
];
@@ -2121,18 +2125,22 @@ mod tests {
continue;
}
let text = std::fs::read_to_string(&p).unwrap_or_default();
// Split so this file cannot match its own walker.
const CALL: &str = concat!("fire_event", "(");
let mut from = 0;
while let Some(i) = text[from..].find(CALL) {
let at = from + i + CALL.len();
from = at;
let rest = text[at..].trim_start();
if let Some(body) = rest.strip_prefix('"') {
if let Some(end) = body.find('"') {
fired
.entry(body[..end].to_string())
.or_insert_with(|| p.display().to_string());
// Split so this file cannot match its own walker. Both spellings of the fire,
// for the reason the producer gate above gives.
const CALLS: [&str; 2] =
[concat!("fire_event", "("), concat!("fire_event_reach", "(")];
for call in CALLS {
let mut from = 0;
while let Some(i) = text[from..].find(call) {
let at = from + i + call.len();
from = at;
let rest = text[at..].trim_start();
if let Some(body) = rest.strip_prefix('"') {
if let Some(end) = body.find('"') {
fired
.entry(body[..end].to_string())
.or_insert_with(|| p.display().to_string());
}
}
}
}