gromandClaude Opus 5
81d96af35d
This checkout had no git history at all, so this one commit carries the whole
of the Everwood work as a single import on top of chairmanpow/benilla-octo's
`main` (706cd71). The two trees have genuinely diverged — each has files the
other does not — so this is a fork point, not a catch-up.
Today's work, which is the reason a baseline exists at all:
- Booth previews no longer cast world shadows (`NO_BOOTH_SHADOW`). Portrait
characters were entering the sun's shadow cascades, so every skinned-rig
shadow specialization compiled live mid-frame; the hitch detector logged
"main thread blocked 1316 ms" beside a `compiled LIVE` warning. This was
the Fashion/Tmog stutter.
- Per-pane dress-up: each `DressUpModel` pane assembles and stages its own
tried-on look instead of every pane mirroring the live player.
- Item template cache is append-only JSONL written on the IO pool, replacing
an 11.6 MB whole-map JSON rewrite on the main thread every 10 s.
- `WOW_SYSTEM_TIMING` rebuilt per-thread: it took 2 mutexes per system enter
and 4 per exit, costing 15 ms a frame (590 fps -> 60) and corrupting the
measurements it was taken to produce.
- The visibility-churn sweep moved to its own `WOW_FLASH_CHURN` switch, so a
frame-cost reading no longer pays 2.7 ms a frame for it.
Local state (`benilla-config/`, `logs/`, `target/`) is excluded by the
existing .gitignore; the account credential it holds is not in this commit.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn
81 lines
3.5 KiB
XML
81 lines
3.5 KiB
XML
<!--
|
|
Adapters over the stock ContainerFrame.xml and .lua; loaded after them, so these win.
|
|
Deviation: our keyring is a container (id -2), not inventory slots as in the reference, so its
|
|
tooltip comes from `SetBagItem`; the stock fork (ContainerFrame.lua:615-620) reads the slots.
|
|
A full keyring prints an empty error line as the reference does: `PutKeyInKeyRing` reads
|
|
`NO_EMPTY_KEYRING_SLOTS`, which 1.12 does not ship.
|
|
-->
|
|
<Ui xmlns="http://www.blizzard.com/wow/ui/">
|
|
<Script><![CDATA[
|
|
-- The stock body, captured before it is shadowed; nil when no client data was sourced.
|
|
local refItemButtonOnEnter = ContainerFrameItemButton_OnEnter
|
|
|
|
function ContainerFrameItemButton_OnEnter(button)
|
|
if not button then
|
|
button = this
|
|
end
|
|
if not button then return end
|
|
|
|
-- The stock bag-slot path, not its inventory-slot keyring detour.
|
|
if button:GetParent():GetID() == KEYRING_CONTAINER then
|
|
if (button:GetRight() or 0) >= (GetScreenWidth() / 2) then
|
|
GameTooltip:SetOwner(button, "ANCHOR_LEFT")
|
|
else
|
|
GameTooltip:SetOwner(button, "ANCHOR_RIGHT")
|
|
end
|
|
GameTooltip:SetBagItem(KEYRING_CONTAINER, button:GetID())
|
|
ResetCursor()
|
|
return
|
|
end
|
|
|
|
if not refItemButtonOnEnter then
|
|
message("benilla: Interface\\FrameXML\\ContainerFrame.lua was not sourced from the "
|
|
.. "game data, so bag-slot tooltips cannot work. Check the client data path.")
|
|
return
|
|
end
|
|
refItemButtonOnEnter(button)
|
|
end
|
|
|
|
-- ══ The three bag verbs benilla answers differently ═══════════════════════════════════
|
|
-- Deviation: `OpenBackpack` opens every equipped bag, not only the backpack, so the vendor,
|
|
-- bank, mail and trade windows that call it bring up every bag to sell or deposit from.
|
|
-- The was-open memory is keyed by bag id: `ContainerFrame1..12` are recycled across bags.
|
|
BENILLA_BAG_WAS_OPEN = {}
|
|
|
|
-- Ignores the was-open memory and covers the bank bags, as ContainerFrame.lua:702-707 does.
|
|
function BenillaCloseAllBags()
|
|
for bagId = 0, (NUM_CONTAINER_FRAMES or -1) do
|
|
CloseBag(bagId)
|
|
end
|
|
end
|
|
|
|
-- The reference's `backpackWasOpen`, one entry per bag: CloseBackpack leaves those open.
|
|
function BenillaOpenBackpack()
|
|
for bagId = 0, (NUM_BAG_FRAMES or -1) do
|
|
-- OpenBag's own test, repeated so the memory agrees with it.
|
|
if bagId == 0 or GetContainerNumSlots(bagId) > 0 then
|
|
if IsBagOpen(bagId) then
|
|
BENILLA_BAG_WAS_OPEN[bagId] = 1
|
|
else
|
|
BENILLA_BAG_WAS_OPEN[bagId] = nil
|
|
OpenBag(bagId)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
function BenillaCloseBackpack()
|
|
for bagId = 0, (NUM_BAG_FRAMES or -1) do
|
|
if not BENILLA_BAG_WAS_OPEN[bagId] then
|
|
CloseBag(bagId)
|
|
end
|
|
end
|
|
end
|
|
|
|
-- After the stock ContainerFrame.lua has loaded, so its callers reach these.
|
|
OpenBackpack = BenillaOpenBackpack
|
|
CloseBackpack = BenillaCloseBackpack
|
|
CloseAllBags = BenillaCloseAllBags
|
|
]]></Script>
|
|
</Ui>
|