Sam SungandClaude Opus 5.5
33c2c5aa70
The fourteen 1.12.1 functions #336 lists are defined, each derived from its reference address, and benilla's layer drops the two places it stood in for the stock bag code. - **Keyring:** `KeyRingButtonIDToInvSlotID` (`0x4c8150`) exists, and the keyring slots answer as inventory slots 82-113. The stock `ContainerFrame.lua:616-619` hover path now runs unchanged, and the layer's keyring `OnEnter` wrapper is deleted. - **Bags:** the layer no longer replaces `CloseAllBags`. The stock one (`ContainerFrame.lua:702-707`) closes the backpack only when it was not open before the vendor or mailbox opened it (#541). The deviation that opens every bag stays, and its comment now names its only callers. - **Inventory:** `ShowInventorySellCursor`, `SetInventoryPortaitTexture` and `UpdateInventoryAlertStatus` exist. - **Character and pet:** `GetDamageBonusStat` (ChrClasses field 2), `GetPetTimeRemaining` (armed from `SMSG_PET_SPELLS`) and `GetActionAutocast` exist. - **Mail:** `ClearSendMail`, `GetNumPackages`, `GetPackageInfo` and `SelectPackage` exist, over a new `Package.dbc` loader. A selected package rides in the mail send. The compose reset now also clears the stationery, the package and the attachment, as `0x4acdc0` does. - **Tabard:** `GetTabardInfo` opens the tabard designer through the registrar (`0x5e00e0`). - **World map:** `GetWorldLocMapPosition` projects a map position onto the displayed map (`0x4a7360`). - **Loot:** `SetLootPortrait` binds a unit loot source's portrait (`0x4c2b40`). Verified: - A test per function for its shapes, raises and effects, failing on main. - A keyring hover test through the stock path, failing on main. - A backpack-over-vendor test, failing on main. - `scripts/gates.sh` and `scripts/smoke.sh` are green. - A live A/B run: hovering a key asked for `player:82` and showed the key's tooltip. After a vendor, opening the Help panel left the backpack open and closed bag 1; on main the backpack closed. Built on macOS; no platform seam touched. Fixes #336 Fixes #541 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
45 lines
2.1 KiB
XML
45 lines
2.1 KiB
XML
<!--
|
|
Adapters over the stock ContainerFrame.xml and .lua; loaded after them, so these win.
|
|
A full keyring prints an empty error line as the reference does: `PutKeyInKeyRing` reads
|
|
`NO_EMPTY_KEYRING_SLOTS`, which 1.12 does not ship.
|
|
-->
|
|
<Ui xmlns="http://www.blizzard.com/wow/ui/">
|
|
<Script><![CDATA[
|
|
-- ══ The two bag verbs benilla answers differently ═════════════════════════════════════
|
|
-- Deviation: `OpenBackpack` opens every equipped bag, not only the backpack, so the vendor
|
|
-- and mailbox windows that call it (MerchantFrame.lua:35, MailFrame.lua:39) bring up every
|
|
-- bag to sell or mail from. The was-open memory is keyed by bag id: `ContainerFrame1..12`
|
|
-- are recycled across bags. The stock `CloseAllBags` (ContainerFrame.lua:702-707) runs
|
|
-- unchanged: it calls this `CloseBackpack`, then closes bags 1 and up.
|
|
BENILLA_BAG_WAS_OPEN = {}
|
|
|
|
-- The reference's `backpackWasOpen`, one entry per bag: CloseBackpack leaves those open.
|
|
function BenillaOpenBackpack()
|
|
for bagId = 0, (NUM_BAG_FRAMES or -1) do
|
|
-- OpenBag's own test, repeated so the memory agrees with it.
|
|
if bagId == 0 or GetContainerNumSlots(bagId) > 0 then
|
|
if IsBagOpen(bagId) then
|
|
BENILLA_BAG_WAS_OPEN[bagId] = 1
|
|
else
|
|
BENILLA_BAG_WAS_OPEN[bagId] = nil
|
|
OpenBag(bagId)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
function BenillaCloseBackpack()
|
|
for bagId = 0, (NUM_BAG_FRAMES or -1) do
|
|
if not BENILLA_BAG_WAS_OPEN[bagId] then
|
|
CloseBag(bagId)
|
|
end
|
|
end
|
|
end
|
|
|
|
-- The stock names, redefined after the stock ContainerFrame.lua has loaded, so its callers
|
|
-- (the vendor and mailbox windows, the vendor's close and `CloseAllBags`) reach these.
|
|
OpenBackpack = BenillaOpenBackpack
|
|
CloseBackpack = BenillaCloseBackpack
|
|
]]></Script>
|
|
</Ui>
|