Files
ClassicAPI/src/guid/Guid.cpp
T
Brues 40abcabe9d fix(unit): read the creature id from the unit's live entry, not the GUID
UnitCreatureID and C_CreatureInfo.GetCreatureID extracted the template from
GUID bits 24-47. On the (v)mangos family that is the spawn row's FIRST
creature id: Creature::CreateFromProto builds the GUID from creature_id[0]
and applies the rolled template through UpdateEntry -> SetEntry only, and a
respawn re-rolls. Turtle's creature table has up to four ids per row (6,935
of 79,773 rows use more than one), so mobs with different names reported the
same id — every Gordunni ogre from a {5236, 5238, 5239} row read 5236.

New Unit::CreatureID reads the entry the engine keys the creature NAME query
on: the instance block at [[unit+0x08]+0x0C] (FUN_00604600's own read), with
the GUID bits only as the out-of-view fallback for creature GUIDs. The
descriptor's OBJECT_FIELD_ENTRY slot reads 0 for creatures on this client,
as it does for items, so it is documented as unusable. Pet GUIDs pack the pet
number, not a template, so Guid::CreatureEntry now returns 0 for them; pets
in view report their real template from the block.

Verified in-game on Turtle: Gordunni Shaman / Battlemaster / Mage-Lord read
5236 / 5238 / 5239 while all three carry 5236 in the GUID.
2026-09-12 23:47:08 -05:00

77 lines
2.6 KiB
C++

// This file is part of ClassicAPI.
//
// ClassicAPI is free software: you can redistribute it and/or modify it under the terms
// of the GNU General Public License as published by the Free Software Foundation, either
// version 3 of the License, or (at your option) any later version.
//
// ClassicAPI is distributed in the hope that it will be useful, but WITHOUT ANY
// WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
// PURPOSE. See the GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License along with
// ClassicAPI. If not, see <https://www.gnu.org/licenses/>.
#include "Guid.h"
#include <cstddef>
#include <cstdio>
#include <cstring>
namespace Guid {
bool Parse(const char *str, uint64_t *out) {
if (str == nullptr)
return false;
if (str[0] != '0' || (str[1] != 'x' && str[1] != 'X'))
return false;
const char *hex = str + 2;
const std::size_t len = std::strlen(hex);
if (len != 8 && len != 16)
return false;
uint64_t value = 0;
for (std::size_t i = 0; i < len; ++i) {
const char c = hex[i];
uint64_t digit;
if (c >= '0' && c <= '9') digit = c - '0';
else if (c >= 'a' && c <= 'f') digit = 10 + (c - 'a');
else if (c >= 'A' && c <= 'F') digit = 10 + (c - 'A');
else return false;
value = (value << 4) | digit;
}
*out = value;
return true;
}
const char *FormatAsString(uint64_t guid, char *buf, std::size_t cap) {
if (buf == nullptr || cap < STRING_SIZE)
return "";
std::snprintf(buf, cap, "0x%08X%08X",
static_cast<uint32_t>(guid >> 32),
static_cast<uint32_t>(guid));
return buf;
}
uint32_t CreatureEntry(uint64_t guid) {
if (Classify(guid) != Type::Creature) // a pet GUID packs the pet number here
return 0;
return static_cast<uint32_t>((guid >> 24) & 0xFFFFFFu);
}
Type Classify(uint64_t guid) {
if (guid == 0)
return Type::Unknown;
const uint16_t prefix = static_cast<uint16_t>(guid >> 48);
switch (prefix) {
case PREFIX_PLAYER: return Type::Player;
case PREFIX_ITEM: return Type::Item;
case PREFIX_CREATURE: return Type::Creature;
case PREFIX_PET: return Type::Pet;
case PREFIX_GAMEOBJECT: return Type::GameObject;
case PREFIX_DYNAMICOBJECT: return Type::DynamicObject;
case PREFIX_CORPSE: return Type::Corpse;
default: return Type::Unknown;
}
}
} // namespace Guid