mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 16:10:36 +00:00
The spell-removal handler FUN_005E9FE0 calls FUN_004E5E20(spellID) right after the unlearn writer. That sweep walks all 0x78 action slots, resolves each through FUN_ACTION_SLOT_TO_SPELL -- which is macro-aware, so a macro slot answers with the primary-spell cache this module writes -- and clears every slot whose spell matches. The clear notifies with sendToServer = 1, so CMSG_SET_ACTION_BUTTON goes out and the server persists it: the macro is gone for good, not until the next reload. That rule is sound for a cache the engine filled from a /cast line and wrong for one filled from a display directive, which names an icon rather than what the button does. `#showtooltip [known:18223] 18223` over a /cast the player can still perform would lose the whole macro on a respec, and a conditional directive makes it arbitrary besides -- the cached value is whichever clause happened to match on the last evaluation. Co-hook the sweep and park every managed macro's cache at 0 for its duration, restoring afterwards with a plain field write (nothing we own changed, so no repaint is owed; the slots the engine really did clear were announced by its own notify). A BusyScope wraps it because the sweep's ACTIONBAR_SLOT_CHANGED handlers reach Lookup, whose catch-up would otherwise re-apply the parked values mid-sweep for slots the loop has yet to reach. Macros with no directive are untouched. Consequence: a plain #showtooltip macro whose /cast line names the unlearned spell now also survives, where stock 1.12 removed it.