mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 08:00:42 +00:00
Turtle's Dark Harvest (52550-52552) makes the caster's Affliction dots on the channel target tick 30% faster - and live preserves each dot's tick COUNT, so the dot's real remaining time drains at 130% rate during the overlap and it falls off early with no client-visible aura change (report: gone with ~3 s still showing; Cursive's community calibration models the same `remaining -= 0.30 x overlap`). tortoise-wow's recreation only re-times tick timers and leaves holder duration alone, which does NOT reproduce the early fall-off - so the compression math mirrors live, while the affected-set predicate mirrors the server script (IsDarkHarvestAfflictionPeriodicAura): same-caster warlock-family auras matching the Corruption/Drain Life/CoA/Drain Soul/Siphon Life/CoD mask with a periodic damage/leech effect (the aura-type gate is load-bearing: Turtle's Atrocity shares Corruption's 0x2 bit but is a proc aura - DBC sweep verified; the trigger mask 0x4000000000 selects exactly the three DH ranks). Aura::Source::AddTickCompression: while a caster's trigger-mask aura is live on a target (its cache entry's lifetime: SpellGo -> OnAuraRemoved eviction), that caster's matching entries drain an extra pct% of real time. Anchored math (expiration = anchor - elapsed x pct/100) so frame pacing can't drift it; an external re-stamp (dot recast, duration mod) re-anchors from the fresh value. Caster-paired like the server, so an observed party warlock's DH compresses their dots' timing too. ~1/s UNIT_AURA nudges for event-driven consumers, final nudge at release. Registered Turtle-gated in turtle/DarkHarvest.cpp with the percent read from the rank record's EffectBasePoints[1]+1 (-31 -> 30, fallback 30). Also: MSG_CHANNEL_UPDATE now re-anchors the cached target-side expiration of the player's channel-applied auras (Aura::Source::RestampPlayerChannel). The server shortens every hit target's holder on channel pushback (Spell::DelayedChannel -> DelaySpellAuraHolder) and only tells the caster via the new remaining time, so the SpellGo-stamped expiration read late by the accumulated pushback; self-target holders were already corrected natively via SMSG_UPDATE_AURA_DURATION. This also bounds the compression window under pushback for free.