mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 08:00:42 +00:00
The engine resolver FUN_OBJECT_RESOLVE_BY_GUID funnels unconditionally into FUN_00464890, whose first action loads the registry root from [VAR_LOCAL_PLAYER_PTR] and derefs its +0x24 hash mask with no null check. That root is NULL out of world (login, loading screens, logout teardown), so any resolve reaching it mid-transition dies with ERROR #132 (MOV EAX,[EDX+0x24], EDX=0) - hit in the wild by Aura::Source's SMSG_SPELL_GO path, whose Store/Claim eviction consults DescriptorListsAura while packets still dispatch during transitions. Promote the readiness predicate from Unit::TokenObserver's private RegistryReady into Object::RegistryReady (object/Resolve.h) and gate ByGuid on it, returning nullptr out of world. That is both the contract ByGuid's comment already promised ("pre-world ... safe from any context") and provably behavior-preserving: a zero result is the engine's own handled "not found" case (verified in Ghidra - 0x468460 null-checks the node; 0x464870 itself returns 0 for guid==0), and out of world the call had no non-crashing outcome. Every ByGuid call site already null-checks. TokenObserver now delegates to the shared helper. Fixes #34