The TWT_UDTSv4/TWTv4= server threat API only ever replies when a
recognized third-party threat addon is also loaded (confirmed against
both TWThreat's and KLHThreatMeter's actual source - neither implements
any reply logic itself, and neither needs a handshake, so the gate
isn't anything a message can unlock). Threat mode now falls back to
estimating threat locally from Aggregator's own tracked damage/healing
data (class + spell threat-coefficient approximations) whenever a poll
happens with no real reply - a real reply always overrides it the
moment one arrives.
Also persists /cl debug across relaunches (CombatLedgerDB.settings),
restored on PLAYER_ENTERING_WORLD ahead of any other file's handler for
that event - debug always resetting to off made it structurally
impossible to capture a fresh login's earliest behavior.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
SPELL_HEAL_ON_SELF was firing alongside SPELL_HEAL_BY_SELF/OTHER for
every heal landing on the player, double-counting it - no longer
registered.
Reflect/thorns-style damage (Retribution Aura, Thorns, etc.) now shows
as its own tracked ability, sourced from Nampower's dedicated
DAMAGE_SHIELD_SELF/OTHER event instead of being invisible or blended
into an unrelated spell's numbers.
Also adds debug logging to the boss-pull classification check for
future troubleshooting (this server doesn't tag dungeon bosses as
elite/worldboss, so pull announcements are known-limited for now).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds a "Casts" stat for DoTs (distinct from tick count) sourced from
real cast events. Replaces the single "clear on join party" checkbox
with Always/Ask options, the latter showing a confirmation popup.
Fixes two regressions where a non-combat event (a cast, then a heal)
could lazy-start a blank encounter well after a fight had genuinely
ended, wiping the just-finished Current Fight display - neither casts
nor healing/cleanses can trigger a new encounter now, only tally into
an already-active one.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Splits direct-hit vs DoT-tick damage into separate Hits/Ticks (and
real Casts vs Ticks for pure DoTs) in the breakdown window, using
Nampower's per-event aura data plus real AURA_CAST cast counts.
Fixes a duration-inflation bug where nearby unrelated combat noise
kept encounters from trimming trailing idle time, and a regression
where the first hit of a fresh pull could be dropped entirely. Also
adds "clear Overall on join party" and narrows pull announcements to
boss-tagged targets only.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Removed the group-wait deferral on PLAYER_REGEN_ENABLED (matches
GreedMeter's own approach - months of real use with no reported
fragmented pulls, so the theoretical raid-fragmentation risk isn't
worth delaying every single stop to guard against)
- The actual bug: RecordDamage/RecordAvoidance/RecordDebuffGiven/
RecordInterrupt had no combat-state guard on their lazy
StartEncounter(), so a stray trailing event after a real fight ended
(a late DoT tick, splash damage) silently spun up a blank new
encounter that immediately overwrote the just-finished fight's frozen
summary - all Record* functions now guard consistently with
AnyoneInCombat(), matching RecordHealing/RecordCleanse
- Bars now snap straight to their final value instead of smoothly
animating when Current Fight has no live encounter running (i.e. it's
showing the frozen last-finished result) - the data finalizes
instantly, but smoothing could take up to ~1s to visually catch up
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Header: drop the title bar, show full Mode/Segment words (adaptive width
instead of jumping per-label), remove the redundant Options button
(minimap right-click already covers it)
- Buttons: fix stuck press/hover colors for good by owning hover/press
state via continuous OnUpdate polling instead of trusting discrete
WoW mouse events, which this client drops once a click opens a new
frame; also stop pfUI's own competing hover hook from fighting it
- Windows: per-window Auto-show/Auto-hide/Grouped-only rules (replacing
the old global-only checkboxes) so e.g. a Threat meter can stay hidden
until grouped and in combat while Damage stays up always; extra
windows are now structurally identical to Main (no per-window close
button - create/close only from Options); Mirror Main copies
size/position in one click; minimap toggle and login/reload restore
now respect these rules instead of ignoring them
- History: kept per-character instead of shared account-wide, with a
one-time migration of old shared data
- Threat: Test Mode now fills Threat mode with dummy bars + the Pull
Aggro At marker, matching every other mode
- Options: removed the non-working pfUI dock toggle, fixed a checkbox
skinning gap, shrunk the window and added section dividers, updated
screenshots/README for the new window-management additions
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Aggregator.lua's Record* functions lazily called StartEncounter()
whenever none was active, with no check on whether anyone was actually
fighting - so a stray post-combat heal tick, HoT finishing, or mana
regen event (all real, all logged by Nampower, none of them combat)
would spin up a brand new encounter out of thin air right after a real
fight ended. It then sat there with near-zero data until the idle
timeout killed it, showing up in History as an empty "fight" that never
happened. Guard it with the same player-or-group UnitAffectingCombat
check already proven correct for the raid-clearing fix.
Also gate the idle-timeout fallback in Events.lua the same way the
regen-based finish already is, so a personal lull doesn't end an
encounter while the group is still genuinely fighting.
- New Encounter Breakdown report window: bucketed damage/healing/taken
time-series per saved encounter with a graph and leaderboard drill-down
- Fix encounters ending prematurely in raids: PLAYER_REGEN_ENABLED no
longer force-finishes while other raid/party members are still
UnitAffectingCombat - waits for the group to actually clear instead
- Threat mode no longer flashes to empty on target swap - holds the
previous target's bars until fresh data lands, or 2s timeout if it
never does
A combat meter for WoW 1.12 built on Nampower's structured combat
events instead of chat-log text parsing. Tracks Damage, Healing,
Damage Taken, Dispels, Debuffs Given, Deaths, and live Threat (via
this server's UnitDetailedThreatSituation addon-message API), each
with click-through per-ability/per-target breakdowns, across any
number of independent meter windows, plus Current/Overall/History
segments and a death recap.