Adds a "Casts" stat for DoTs (distinct from tick count) sourced from
real cast events. Replaces the single "clear on join party" checkbox
with Always/Ask options, the latter showing a confirmation popup.
Fixes two regressions where a non-combat event (a cast, then a heal)
could lazy-start a blank encounter well after a fight had genuinely
ended, wiping the just-finished Current Fight display - neither casts
nor healing/cleanses can trigger a new encounter now, only tally into
an already-active one.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Splits direct-hit vs DoT-tick damage into separate Hits/Ticks (and
real Casts vs Ticks for pure DoTs) in the breakdown window, using
Nampower's per-event aura data plus real AURA_CAST cast counts.
Fixes a duration-inflation bug where nearby unrelated combat noise
kept encounters from trimming trailing idle time, and a regression
where the first hit of a fresh pull could be dropped entirely. Also
adds "clear Overall on join party" and narrows pull announcements to
boss-tagged targets only.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- New "Highlight my bar" color picker (was hardcoded gold) and new
"Show bar border" toggle + color, applying to every bar - both share
a new CreateColorSwatch helper wired to Blizzard's own
ColorPickerFrame (live preview, reverts on cancel)
- Fixed a real bug found while building this: the border used to be a
plain SetBackdrop directly on the bar's own StatusBar frame, which
draws on the same layer as (and gets covered by) the bar's fill and
background textures - only a sliver was ever visible. Now a
dedicated child overlay frame at a higher frame level, so the border
always renders fully on top regardless of fill %
- Highlight my bar always wins over the general border on your own row
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Every CombatLedger window (meter, Options, DeathRecap) now sits at
MEDIUM, matching History/Breakdown/EncounterReport which already
rendered correctly below Blizzard's own Character/Bags/Quest-dialog
panels - FULLSCREEN_DIALOG/DIALOG/HIGH all still rendered above them
on this client
- CL.ShowDropdown submenus no longer hardcode TOOLTIP - they compute
CL.NextHigherStrata(anchor's current strata) each time instead, so
they still reliably render above whatever opened them without
needing to unconditionally outrank every other addon's UI
- Dropdowns now open upward instead of downward when there isn't room
below the anchor to fit on screen - meter windows commonly sit low
on screen, where a downward-only dropdown routinely ran off-screen
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Header: drop the title bar, show full Mode/Segment words (adaptive width
instead of jumping per-label), remove the redundant Options button
(minimap right-click already covers it)
- Buttons: fix stuck press/hover colors for good by owning hover/press
state via continuous OnUpdate polling instead of trusting discrete
WoW mouse events, which this client drops once a click opens a new
frame; also stop pfUI's own competing hover hook from fighting it
- Windows: per-window Auto-show/Auto-hide/Grouped-only rules (replacing
the old global-only checkboxes) so e.g. a Threat meter can stay hidden
until grouped and in combat while Damage stays up always; extra
windows are now structurally identical to Main (no per-window close
button - create/close only from Options); Mirror Main copies
size/position in one click; minimap toggle and login/reload restore
now respect these rules instead of ignoring them
- History: kept per-character instead of shared account-wide, with a
one-time migration of old shared data
- Threat: Test Mode now fills Threat mode with dummy bars + the Pull
Aggro At marker, matching every other mode
- Options: removed the non-working pfUI dock toggle, fixed a checkbox
skinning gap, shrunk the window and added section dividers, updated
screenshots/README for the new window-management additions
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
New-user feedback batch:
- New optional pfUI right-chat-panel dock (UI_PfuiDock.lua), using
pfUI's real pfUI.thirdparty.meters:RegisterMeter API (same one
TWThreat/SW_Stats/KTM use) - opt-in via Options, off by default.
- New "Show class icon" option - a real class icon before the name on
each bar, independent of the existing class-colored fill.
- Spell/melee icons added to the breakdown window: the "Top Ability"
stat row, and a large icon next to the name when a specific ability
is selected in the detail panel.
- Fixed text collision across the breakdown window (detail rows,
per-ability icon list, target list) and proactively in the main
window's bars - name text was never bounded against value text in
any of them, so long names/values could run into each other.
- Main window raised to TOOLTIP strata (highest) so it can't end up
hidden behind other windows.
- Every CombatLedger window now uses SetClampedToScreen(true) - can no
longer be dragged/pushed off-screen.
- CL.HasPfui() was inferring pfUI's presence from the shape of the
`pfUI` global (existence, then pfUI.api, then a specific function on
it) - all of which stayed true on a client with pfUI genuinely not
loaded (confirmed via IsAddOnLoaded returning false, plus a
completely unstyled vanilla UI). Something else on this client fully
populates a pfUI-shaped table without pfUI ever loading. Switched to
IsAddOnLoaded("pfUI") directly - authoritative, sidesteps the whole
problem. Fixes "Match pfUI" staying visible/active with pfUI off.
- Resized the four bundled bar textures (ElvUI/Gradient/Striped/TukUI)
from 256x32 to square 32x32 - this client only loads square status
bar textures, not just power-of-two on each axis, which is why they
silently fell back to whatever was already showing. Also added a
generated square "Smooth Gradient" texture, replacing Blizzard's own
Raid-Bar-Hp-Fill (same non-square problem, can't be fixed directly).
- Bar texture/Font/Number format in Options are now real dropdowns
(click opens the full list, same widget the Mode/Segment buttons use)
instead of cycle-on-click - moved the shared dropdown widget into
Core.lua (CL.ShowDropdown) so both files use one implementation.
- Swept the remaining Blizzard rounded-Tooltip-style backdrops (History
rows/buttons, Report toggle buttons, Options window/buttons, the
dropdown menu) to the same flat WHITE8X8 style already applied to the
main window, for visual consistency.
- Fixed button hover leaving the border stuck class-colored - the
restore-on-leave logic still used the old theme-color params instead
of the new flat near-black default.
- Window opacity can now go down to 0%.
- Bundled pfUI's default bar texture (img/bar.tga, MIT-licensed) directly
in this addon so its flat look is the default appearance for everyone,
not just pfUI users - "Match pfUI" previously meant the good-looking
theme was exclusive to people who happened to already run pfUI.
- Added a "Hide window border" option (ShaguDPS-style), independent of
Match pfUI.
- Fixed the header looking like garbled overlapping text at a narrow
resize - the title sits centered on the same row as the header
buttons, and nothing constrained it, so a long mode title (e.g.
"Debuffs Given") could render wider than the actual gap between the
button clusters. Now hidden below the width where it would visibly
overlap, measured against its real string width rather than a guessed
threshold.
RestoreState's staleness check ("startTime <= GetTime()") wasn't
actually testing same-process-ness - GetTime() resets to a small number
on every fresh client launch too, not just across a same-process
/reload, so an old saved encounter that itself started early in its own
session could coincidentally still satisfy the check on a brand new
process and get wrongly restored as still-live. That silently absorbed
the real session's first hit into the stale encounter, which the idle
timeout then finished/discarded before the real pull started -
reported as "the first hit of a new session isn't recorded" (e.g. Mind
Blast missing while Holy Fire/Smite after it recorded fine). Added a
wall-clock companion timestamp (time(), never resets across any
boundary) so the restore check is a real same-process test instead of
a coincidental number comparison.
Also swapped the minimap button icon (was Ability_DualWield) - it
collided with this server's preinstalled BG Finder addon using the
exact same icon.
Also reverted the AnyoneInCombat combat-state guard on
RecordDamage/RecordAvoidance/RecordDebuffGiven/RecordInterrupt back to
unconditional lazy-start - those only ever happen as part of actually
engaging a hostile target, so gating them on UnitAffectingCombat risked
racing the regen flag on a fresh pull. Kept the guard on RecordHealing/
RecordCleanse, which do legitimately fire with nobody in combat
(post-fight top-off heals, mana ticks).
A combat meter for WoW 1.12 built on Nampower's structured combat
events instead of chat-log text parsing. Tracks Damage, Healing,
Damage Taken, Dispels, Debuffs Given, Deaths, and live Threat (via
this server's UnitDetailedThreatSituation addon-message API), each
with click-through per-ability/per-target breakdowns, across any
number of independent meter windows, plus Current/Overall/History
segments and a death recap.