Commit Graph
26 Commits
Author SHA1 Message Date
Si Ha b362979575 Rename Spells missed to Abilities missed (includes melee specials) 2026-09-28 02:06:04 +02:00
Si Ha 3a1a403469 Show spell misses as a percentage of spell attempts (casts for DoTs and non-damage spells) 2026-09-28 02:02:12 +02:00
Si Ha 28caf9746b Show misses right after hit counts in the ability detail panel; compact Total and average lines 2026-09-28 01:58:09 +02:00
Si Ha 30d56ac002 Add option to turn off the bar hover tooltip 2026-09-28 01:49:03 +02:00
Si Ha 7da485b8c0 Reset clears Current Fight and Overall (never a live fight, History kept); rename Clear Overall to Auto reset 2026-09-28 01:04:46 +02:00
Si Ha 43bffedc33 Add reset rules for joining/leaving a group and entering an instance, per-window in-combat mode 2026-09-27 20:01:23 +02:00
Si Ha 7e5f0425d8 Detect boss fights via BigWigs engaged modules and enable triggers, name saved boss fights by encounter 2026-09-27 19:56:21 +02:00
Si Ha 59fc9a0304 Isolate handler errors with /cl status diagnostics, remove dead code, rewrite comments as intent 2026-09-27 19:49:44 +02:00
Si Ha fdd1bfadc2 Bound saved data: name-keyed Overall targets, compact history on save, add Saved fights and Remember boss fights only options 2026-09-27 19:24:54 +02:00
Si Ha 54c37adb47 Rebuild local threat estimate as per-event ledger with pets, stances, forms and buffs; add Merge pets into owners option 2026-09-27 19:16:18 +02:00
Si Ha 2886bc7e1f Record absorbed/blocked/resisted amounts and glancing/crushing hits; pass melee resist arg 2026-09-27 19:08:57 +02:00
Si Ha 8c422b027b Record spell misses/resists and environmental damage from Nampower events 2026-09-27 19:05:24 +02:00
Si Ha fedcada0f0 Track effective healing with estimated overheal from target health 2026-09-27 19:00:04 +02:00
kobeniiiiiiandClaude Sonnet 5 80d03d502c Add local threat estimation fallback, persist debug flag across sessions
The TWT_UDTSv4/TWTv4= server threat API only ever replies when a
recognized third-party threat addon is also loaded (confirmed against
both TWThreat's and KLHThreatMeter's actual source - neither implements
any reply logic itself, and neither needs a handshake, so the gate
isn't anything a message can unlock). Threat mode now falls back to
estimating threat locally from Aggregator's own tracked damage/healing
data (class + spell threat-coefficient approximations) whenever a poll
happens with no real reply - a real reply always overrides it the
moment one arrives.

Also persists /cl debug across relaunches (CombatLedgerDB.settings),
restored on PLAYER_ENTERING_WORLD ahead of any other file's handler for
that event - debug always resetting to off made it structurally
impossible to capture a fresh login's earliest behavior.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-22 23:07:53 -05:00
kobeniiiiiiandClaude Sonnet 5 2d23b042c4 Add keybind to toggle CombatLedger windows
Binds to CombatLedger.UI.Toggle() (already shows/hides the main window
plus every extra window together) via a standard Bindings.xml entry,
configurable from the Key Bindings menu.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-22 18:33:07 -05:00
kobeniiiiiiandClaude Sonnet 5 516d4f66a9 Add real per-cast DoT tracking, join-party clear prompt, fix phantom-encounter regressions
Adds a "Casts" stat for DoTs (distinct from tick count) sourced from
real cast events. Replaces the single "clear on join party" checkbox
with Always/Ask options, the latter showing a confirmation popup.

Fixes two regressions where a non-combat event (a cast, then a heal)
could lazy-start a blank encounter well after a fight had genuinely
ended, wiping the just-finished Current Fight display - neither casts
nor healing/cleanses can trigger a new encounter now, only tally into
an already-active one.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-22 09:32:14 -05:00
kobeniiiiiiandClaude Sonnet 5 2f71d1bb43 Split DoT hits from ticks, add clear-on-join-party, boss-only pull announce
Splits direct-hit vs DoT-tick damage into separate Hits/Ticks (and
real Casts vs Ticks for pure DoTs) in the breakdown window, using
Nampower's per-event aura data plus real AURA_CAST cast counts.
Fixes a duration-inflation bug where nearby unrelated combat noise
kept encounters from trimming trailing idle time, and a regression
where the first hit of a fresh pull could be dropped entirely. Also
adds "clear Overall on join party" and narrows pull announcements to
boss-tagged targets only.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-22 09:04:47 -05:00
kobeniiiiiiandClaude Sonnet 5 4d4957ec72 Add bar border options with color pickers
- New "Highlight my bar" color picker (was hardcoded gold) and new
  "Show bar border" toggle + color, applying to every bar - both share
  a new CreateColorSwatch helper wired to Blizzard's own
  ColorPickerFrame (live preview, reverts on cancel)
- Fixed a real bug found while building this: the border used to be a
  plain SetBackdrop directly on the bar's own StatusBar frame, which
  draws on the same layer as (and gets covered by) the bar's fill and
  background textures - only a sliver was ever visible. Now a
  dedicated child overlay frame at a higher frame level, so the border
  always renders fully on top regardless of fill %
- Highlight my bar always wins over the general border on your own row

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-21 20:22:39 -05:00
kobeniiiiiiandClaude Sonnet 5 929c904c7a Lower window strata so nothing covers Character/Bags, dropdowns flip up when clipped
- Every CombatLedger window (meter, Options, DeathRecap) now sits at
  MEDIUM, matching History/Breakdown/EncounterReport which already
  rendered correctly below Blizzard's own Character/Bags/Quest-dialog
  panels - FULLSCREEN_DIALOG/DIALOG/HIGH all still rendered above them
  on this client
- CL.ShowDropdown submenus no longer hardcode TOOLTIP - they compute
  CL.NextHigherStrata(anchor's current strata) each time instead, so
  they still reliably render above whatever opened them without
  needing to unconditionally outrank every other addon's UI
- Dropdowns now open upward instead of downward when there isn't room
  below the anchor to fit on screen - meter windows commonly sit low
  on screen, where a downward-only dropdown routinely ran off-screen

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-21 20:02:43 -05:00
kobeniiiiiiandClaude Sonnet 5 78cbaaf00d Header redesign, per-window auto-show/hide/grouped rules, and reliability fixes
- Header: drop the title bar, show full Mode/Segment words (adaptive width
  instead of jumping per-label), remove the redundant Options button
  (minimap right-click already covers it)
- Buttons: fix stuck press/hover colors for good by owning hover/press
  state via continuous OnUpdate polling instead of trusting discrete
  WoW mouse events, which this client drops once a click opens a new
  frame; also stop pfUI's own competing hover hook from fighting it
- Windows: per-window Auto-show/Auto-hide/Grouped-only rules (replacing
  the old global-only checkboxes) so e.g. a Threat meter can stay hidden
  until grouped and in combat while Damage stays up always; extra
  windows are now structurally identical to Main (no per-window close
  button - create/close only from Options); Mirror Main copies
  size/position in one click; minimap toggle and login/reload restore
  now respect these rules instead of ignoring them
- History: kept per-character instead of shared account-wide, with a
  one-time migration of old shared data
- Threat: Test Mode now fills Threat mode with dummy bars + the Pull
  Aggro At marker, matching every other mode
- Options: removed the non-working pfUI dock toggle, fixed a checkbox
  skinning gap, shrunk the window and added section dividers, updated
  screenshots/README for the new window-management additions

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-21 13:37:18 -05:00
kobeniiiiii 405ab47224 Fix class icons rendering blank, fix dropdown strata collision
- Class icons showed nothing despite loading/sizing correctly (confirmed
  via debug logging) - the stock Blizzard UI-Classes-Circle atlas
  silently fails to render on this client, same class of issue as
  earlier bar textures. Swapped to pfUI's own bundled classicons.tga
  (square, MIT-licensed, same CLASS_ICON_TCOORDS layout) instead.
- Class icons now scale with the "Bar size" Options setting instead of
  staying a fixed size from whenever the bar was first created.
- Fixed the dropdown submenu rendering as a tangled mess interleaved
  with the bar rows - putting the main window at TOOLTIP strata (to fix
  the window-behind-other-windows issue) meant its child frames
  inherited TOOLTIP too, landing in the same strata bucket as the
  dropdown and falling back to ambiguous frame-level ordering. Window
  now sits one level down (FULLSCREEN_DIALOG), leaving TOOLTIP reserved
  exclusively for the dropdown/submenus.
- Window shadows now compute one strata below whatever window they're
  attached to (CL.NextLowerStrata) instead of a hardcoded BACKGROUND,
  which left a large gap for other addons to render into once windows
  moved higher up the strata order.
- Removed a dead code path in RestyleAll left over from moving the
  dropdown into Core.lua (referenced a local that no longer existed in
  this file - harmless since dropdown rows already re-apply their own
  font on every open, but was silently doing nothing).
2026-08-21 10:37:49 -05:00
kobeniiiiii 5cc3a7478e Add pfUI chat dock, class icons, ability icons, fix text collision and window bounds
New-user feedback batch:
- New optional pfUI right-chat-panel dock (UI_PfuiDock.lua), using
  pfUI's real pfUI.thirdparty.meters:RegisterMeter API (same one
  TWThreat/SW_Stats/KTM use) - opt-in via Options, off by default.
- New "Show class icon" option - a real class icon before the name on
  each bar, independent of the existing class-colored fill.
- Spell/melee icons added to the breakdown window: the "Top Ability"
  stat row, and a large icon next to the name when a specific ability
  is selected in the detail panel.
- Fixed text collision across the breakdown window (detail rows,
  per-ability icon list, target list) and proactively in the main
  window's bars - name text was never bounded against value text in
  any of them, so long names/values could run into each other.
- Main window raised to TOOLTIP strata (highest) so it can't end up
  hidden behind other windows.
- Every CombatLedger window now uses SetClampedToScreen(true) - can no
  longer be dragged/pushed off-screen.
2026-08-21 10:24:04 -05:00
kobeniiiiii 53ed531e92 Fix pfUI false-positive detection, square bar textures, add real dropdowns
- CL.HasPfui() was inferring pfUI's presence from the shape of the
  `pfUI` global (existence, then pfUI.api, then a specific function on
  it) - all of which stayed true on a client with pfUI genuinely not
  loaded (confirmed via IsAddOnLoaded returning false, plus a
  completely unstyled vanilla UI). Something else on this client fully
  populates a pfUI-shaped table without pfUI ever loading. Switched to
  IsAddOnLoaded("pfUI") directly - authoritative, sidesteps the whole
  problem. Fixes "Match pfUI" staying visible/active with pfUI off.
- Resized the four bundled bar textures (ElvUI/Gradient/Striped/TukUI)
  from 256x32 to square 32x32 - this client only loads square status
  bar textures, not just power-of-two on each axis, which is why they
  silently fell back to whatever was already showing. Also added a
  generated square "Smooth Gradient" texture, replacing Blizzard's own
  Raid-Bar-Hp-Fill (same non-square problem, can't be fixed directly).
- Bar texture/Font/Number format in Options are now real dropdowns
  (click opens the full list, same widget the Mode/Segment buttons use)
  instead of cycle-on-click - moved the shared dropdown widget into
  Core.lua (CL.ShowDropdown) so both files use one implementation.
- Swept the remaining Blizzard rounded-Tooltip-style backdrops (History
  rows/buttons, Report toggle buttons, Options window/buttons, the
  dropdown menu) to the same flat WHITE8X8 style already applied to the
  main window, for visual consistency.
- Fixed button hover leaving the border stuck class-colored - the
  restore-on-leave logic still used the old theme-color params instead
  of the new flat near-black default.
- Window opacity can now go down to 0%.
2026-08-21 09:42:57 -05:00
kobeniiiiii f8a4b77fd4 Replicate pfUI's exact look without requiring pfUI installed
- Window/button chrome: flat WHITE8X8 panel (was Blizzard's rounded
  Tooltip border) with a near-black border/background matching one real
  pfUI user's own tweaked appearance settings, plus pfUI's own soft
  drop shadow (img/glow2.tga, bundled) - this is now the default look
  regardless of whether pfUI is installed, not just available to people
  who already run pfUI via "Match pfUI".
- Bar textures: bundled all four of pfUI's alternate bar skins (ElvUI/
  Gradient/Striped/TukUI) as real files, fixing the picker entries that
  previously pointed at pfUI.media keys that don't actually exist
  (always silently no-opped instead of changing anything).
- Added the Expressway font (bundled from pfUI, MIT-licensed) as a
  font choice - not a stock client font.

All bundled assets are pfUI's own (Eric Mauser / Shagu), MIT-licensed -
see README credits.
2026-08-21 08:37:20 -05:00
kobeniiiiii 2a9382cec2 Bundle pfUI's flat bar look as the default, add hide-border option, fix min-width header overlap
- Bundled pfUI's default bar texture (img/bar.tga, MIT-licensed) directly
  in this addon so its flat look is the default appearance for everyone,
  not just pfUI users - "Match pfUI" previously meant the good-looking
  theme was exclusive to people who happened to already run pfUI.
- Added a "Hide window border" option (ShaguDPS-style), independent of
  Match pfUI.
- Fixed the header looking like garbled overlapping text at a narrow
  resize - the title sits centered on the same row as the header
  buttons, and nothing constrained it, so a long mode title (e.g.
  "Debuffs Given") could render wider than the actual gap between the
  button clusters. Now hidden below the width where it would visibly
  overlap, measured against its real string width rather than a guessed
  threshold.
2026-08-21 08:15:05 -05:00
kobeniiiiii c4c0547284 Initial commit: CombatLedger v0.3.0
A combat meter for WoW 1.12 built on Nampower's structured combat
events instead of chat-log text parsing. Tracks Damage, Healing,
Damage Taken, Dispels, Debuffs Given, Deaths, and live Threat (via
this server's UnitDetailedThreatSituation addon-message API), each
with click-through per-ability/per-target breakdowns, across any
number of independent meter windows, plus Current/Overall/History
segments and a death recap.
2026-08-20 15:54:38 -05:00