Commit Graph

93 Commits

Author SHA1 Message Date
Brues ea79f083f3 defeats the purpose of the addon and confuses users 2026-07-20 15:38:27 -05:00
Brues 0229b07122 removed Babble 2026-06-23 14:28:20 -05:00
Brues 615c074a3f add ClassicAPI dep 2026-06-23 02:25:27 -05:00
Brues dc88b69103 Add BigWigs packager config to bundle both addons in one zip
Add .pkgmeta (package-as MikScrollingBattleText, move-folders pulling both addon folders to top-level siblings) and a tag-triggered GitHub Actions workflow using BigWigsMods/packager that attaches the single zip to an auto-created GitHub release. Switch both TOCs' Version to the @project-version@ substitution token so the packager stamps the git tag version.
2026-06-23 02:19:35 -05:00
Brues 9f88f0bf32 Replace FindBuff tooltip scanning with C_UnitAuras/C_Item
GetAuraIcon resolves buff/debuff icons via C_UnitAuras.GetAuraDataBySpellName (returns the icon directly, no UnitBuff/UnitDebuff follow-up) and temporary weapon-enchant icons via C_Item.GetWeaponEnchantInfo + C_Item.GetEnchantInfo + C_Spell.GetSpellTexture. This drops ~48 tooltip create/scan/hide ops per uncached effect and, unlike the old FindBuff, actually yields an icon for weapon-enchant-named effects. The dead tracking-spell branch is removed, the AddAnimation call site no longer dead-ends on non-matches (falls through to the spellId/Babble/item resolvers), and the now-unused MSBT_Tooltip frame is removed from the XML.
2026-06-23 02:10:07 -05:00
Brues 9d0f945c59 Make FindItemIcon return the icon consistently from both paths
The equipped-slot path returned (slot, nil, icon, count) while the bag path returned just the icon. The sole caller (AddAnimation) uses only the first return value as the texture, so equipped items produced a slot number instead of an icon path. Both paths now return the icon as the first value. Also call FindItemIcon once in the caller instead of three times, folding the no-icon case into the same branch.
2026-06-22 19:15:30 -05:00
Brues 8c35b8b6ad Fix equipped-item match in FindItemIcon and drop the link loop
The equipped-slot check compared itemName to its own lowercase (always matching the first named slot) instead of the searched item; now it compares against item. The separate GetInventoryItemLink/ItemLinkToName loop for slots past INVSLOT_LAST_EQUIPPED is folded into the ItemLocation loop by extending its range by 4.
2026-06-22 19:09:27 -05:00
Brues 6418359865 use IsPlayerGuid from classicapi 2026-06-22 19:00:58 -05:00
Brues f42c2cf6ca Drop spellNameCache; C_Spell.GetSpellName is a cheap DBC read
The cache originally wrapped the SuperWoW/Nampower pcall fallback chain, where it mattered. Now that GetSpellNameFromId is a single C_Spell.GetSpellName call (a single-field DBC + locale read), the cache only saved a boundary crossing and a string-intern hash per repeated lookup -- and Lua 5.0 interns strings, so it never saved allocations. Not worth the extra table and branch.
2026-06-22 18:49:32 -05:00
Brues c095b76d10 Drop hasNampower gate on UnitGUID calls (provided by ClassicAPI)
UnitGUID is supplied by ClassicAPI, so player/pet GUID resolution no longer needs to be conditional on Nampower. Simplifies the player GUID caching (Init + PLAYER_ENTERING_WORLD retry), IsPetGUID, and EnsurePlayerGUID. GetNameFromGUID stays on Nampower's GetUnitField since it resolves NPC names too, which ClassicAPI's player-only UnitNameFromGUID does not cover.
2026-06-22 18:16:22 -05:00
Brues e8b3b81241 Remove SuperWoW and UnitXP SP3 integration
Drops the SuperWoW and UnitXP SP3 detection flags and all their code paths. GUID/unit-name resolution (GetNameFromGUID, IsPetGUID, EnsurePlayerGUID, player GUID caching) now relies solely on Nampower APIs; the spellId icon fast path keeps only its Nampower branch; and GetUnitIDFromName falls back to the raw-combat-logging path and name cache. UnitXP was detection-only and never read. README updated to reflect the removal.
2026-06-22 18:12:51 -05:00
Brues d13a4102b8 Document ClassicAPI requirement; deprecate SuperWoW/UnitXP
Add a Requirements section noting MSBT now depends on the ClassicAPI client DLL for C_Spell/C_Item/ItemLocation/CreateColor. Retitle the integration section to focus on Nampower and mark the SuperWoW and UnitXP SP3 paths as deprecated and slated for removal.
2026-06-22 18:07:57 -05:00
Brues dce8df9e12 Normalize indentation in GetUnorderedCaptureDataTable
Convert the function body from 2-space to single-space (tab-style) indentation to match the surrounding file. No behavior change.
2026-06-22 18:02:34 -05:00
Brues 7502df37cf Change nampower school table to sequential index keys
nampowerSchoolToType now uses sequential keys (0=Physical, then implicit 1-6 for Holy/Fire/Nature/Frost/Shadow/Arcane) instead of the previous power-of-two bitmask keys (0,1,2,4,8,16,32).
2026-06-22 18:02:34 -05:00
Brues bf5be40e78 Use C_Spell/C_Item APIs for spell name and item icon lookups
GetSpellNameFromId now calls C_Spell.GetSpellName instead of the SuperWoW/Nampower pcall chain. FindItemIcon iterates equipped slots and bags via ItemLocation and C_Item.GetItemName/GetItemIcon. AddAnimation hoists strlower(name) into a local lowerName to avoid repeated calls and feeds the lowercased name to FindItemIcon.
2026-06-22 18:00:24 -05:00
Brues 6a9dd18ce0 Use CreateColor for damage type text coloring
Replace the manual {r,g,b} table and hex color-prefix strings with CreateColor-based color objects. GetDamageTypeFontColor now builds each school color via a CreateSpellColor helper that also caches a colorStr markup string, adds a Holy color, and retunes the existing school colors. FormatEventText and AddAnimation consume the new objects (color.colorStr and dtColor:GetRGB()), and the dead GetDamageTypeColor lookup is removed.
2026-06-22 18:00:04 -05:00
Brues 3f08a237de add Numen font 2026-06-22 17:52:29 -05:00
Arizonacan723 2039d46d9e Merge remote-tracking branch 'upstream/master' 2026-04-06 16:33:27 -07:00
Jrc13245 c6e246c134 fixes 2026-04-06 13:50:29 -04:00
Jrc13245 1ec1c79fd9 fix duplicate buff notifications 2026-03-21 21:37:38 -04:00
Jrc13245 cf233d2e6a fix errors: 2026-03-21 17:43:43 -04:00
Jrc13245 0ba5bd0ebd fix some incoming damage mistaken as outgoing, make sure all damage text has a color for its damage type 2026-03-21 14:44:23 -04:00
Torio e9812fcd9e Merge pull request #3 from DCV-2142/master
Added 6 missing spells + fixed healer names not showing up
2026-03-19 13:06:14 -04:00
DCV-2142 882bcb3783 Merge branch 'master' of https://github.com/DCV-2142/Vanilla_MikScrollingBattleText 2026-03-13 02:11:55 +02:00
DCV-2142 140feda4a0 Fixed incorrect nampower icons for 2 spells
Flametongue attack + Stratholme Holy Water
2026-03-13 02:11:35 +02:00
DCV-2142 d95e203505 Merge branch 'jrc13245:master' into master 2026-03-13 02:09:00 +02:00
Jrc13245 4b236e8446 fix evade event handling 2026-03-12 19:25:33 -04:00
DCV-2142 790d96d9e0 Fixed incoming heals not showing healer's name 2026-03-09 17:11:16 +02:00
DCV-2142 2ec7cf698c Added 6 missing spells
Added:
Flametongue Attack (flametongue totem proc)
Surprise attack          (rogue)
Shadow of Death	  (rogue)
Mark for Death	  (rogue)
Master Strike		  (warrior)
Deep Wound             (warrior -- corrected typo on already existing entries)
2026-02-27 16:46:45 +02:00
Jrc13245 7d3b9ba1b8 fix pet damage 2026-02-14 10:48:44 -05:00
Jrc13245 33b8b58255 fix old errors and improve efficiency and resource usage 2026-02-13 16:27:29 -05:00
Jrc13245 f2065abcfc change spell dmg color by type outgoing only 2026-02-11 18:25:01 -05:00
Jrc13245 684bc9190e fix playerguid race condition 2026-02-11 17:47:12 -05:00
Jrc13245 f8d213d89a updates to fix for users not seeing anything in their incoming and outgoing 2026-02-11 17:22:54 -05:00
Jrc13245 df2bafb8a6 fix outgoing damage bug and improve performance 2026-02-11 16:51:07 -05:00
Jrc13245 53d82a0ad1 dll updates 2026-02-10 15:56:04 -05:00
Jrc13245 cfdab18f86 Merge commit 'refs/pull/1/head' of https://github.com/jrc13245/Vanilla_MikScrollingBattleText
# Conflicts:
#	MikScrollingBattleText/Libs/BabbleSpell-2.2/Babble-Spell-2.2.lua
2026-02-10 13:40:14 -05:00
pepopo978 70af924461 add some missing spells 2025-12-10 12:55:29 -08:00
pepopo978 2e9163cb3f Merge pull request #6 from DaMaGepyHUN/patch-1
Update Babble-Spell-2.2.lua
2025-09-30 16:43:43 -07:00
DaMaGepyHUN 047bb1160b Update Babble-Spell-2.2.lua
Added (warlock): Dark Harvest
2025-10-01 01:12:09 +02:00
pepopo978 84f754d0ef Merge pull request #5 from Bestoriop/master
Adding Holy strike
2025-09-29 08:49:10 -07:00
Bestoriop c66bbaf295 Adding Crusader strike 2025-09-28 15:33:52 +02:00
Bestoriop 58d25b9ce9 Adding Holy strike 2025-09-27 19:15:33 +02:00
LaYt 52f87d3af8 update 2025-08-05 15:29:59 -04:00
shikulja 8f55f6c1f1 upd loc strings, add ru loc (by Maus) 2025-08-05 15:20:20 -04:00
pepopo978 f2bd4700fa add piercing shots 2025-07-13 09:37:03 -07:00
pepopo978 6b8745045d fix extra shot 2025-07-13 09:25:40 -07:00
pepopo978 9b036bda5a add some icons 2025-07-13 09:10:08 -07:00
pepopo978 59a33c9023 Update Babble-Spell-2.2.lua 2025-07-13 08:43:04 -07:00
pepopo978 88a6cc1956 add pain spike 2025-06-19 08:32:39 -07:00