Commit Graph

32 Commits

Author SHA1 Message Date
Brues 6418359865 use IsPlayerGuid from classicapi 2026-06-22 19:00:58 -05:00
Brues f42c2cf6ca Drop spellNameCache; C_Spell.GetSpellName is a cheap DBC read
The cache originally wrapped the SuperWoW/Nampower pcall fallback chain, where it mattered. Now that GetSpellNameFromId is a single C_Spell.GetSpellName call (a single-field DBC + locale read), the cache only saved a boundary crossing and a string-intern hash per repeated lookup -- and Lua 5.0 interns strings, so it never saved allocations. Not worth the extra table and branch.
2026-06-22 18:49:32 -05:00
Brues c095b76d10 Drop hasNampower gate on UnitGUID calls (provided by ClassicAPI)
UnitGUID is supplied by ClassicAPI, so player/pet GUID resolution no longer needs to be conditional on Nampower. Simplifies the player GUID caching (Init + PLAYER_ENTERING_WORLD retry), IsPetGUID, and EnsurePlayerGUID. GetNameFromGUID stays on Nampower's GetUnitField since it resolves NPC names too, which ClassicAPI's player-only UnitNameFromGUID does not cover.
2026-06-22 18:16:22 -05:00
Brues e8b3b81241 Remove SuperWoW and UnitXP SP3 integration
Drops the SuperWoW and UnitXP SP3 detection flags and all their code paths. GUID/unit-name resolution (GetNameFromGUID, IsPetGUID, EnsurePlayerGUID, player GUID caching) now relies solely on Nampower APIs; the spellId icon fast path keeps only its Nampower branch; and GetUnitIDFromName falls back to the raw-combat-logging path and name cache. UnitXP was detection-only and never read. README updated to reflect the removal.
2026-06-22 18:12:51 -05:00
Brues dce8df9e12 Normalize indentation in GetUnorderedCaptureDataTable
Convert the function body from 2-space to single-space (tab-style) indentation to match the surrounding file. No behavior change.
2026-06-22 18:02:34 -05:00
Brues 7502df37cf Change nampower school table to sequential index keys
nampowerSchoolToType now uses sequential keys (0=Physical, then implicit 1-6 for Holy/Fire/Nature/Frost/Shadow/Arcane) instead of the previous power-of-two bitmask keys (0,1,2,4,8,16,32).
2026-06-22 18:02:34 -05:00
Brues bf5be40e78 Use C_Spell/C_Item APIs for spell name and item icon lookups
GetSpellNameFromId now calls C_Spell.GetSpellName instead of the SuperWoW/Nampower pcall chain. FindItemIcon iterates equipped slots and bags via ItemLocation and C_Item.GetItemName/GetItemIcon. AddAnimation hoists strlower(name) into a local lowerName to avoid repeated calls and feeds the lowercased name to FindItemIcon.
2026-06-22 18:00:24 -05:00
Arizonacan723 2039d46d9e Merge remote-tracking branch 'upstream/master' 2026-04-06 16:33:27 -07:00
Jrc13245 c6e246c134 fixes 2026-04-06 13:50:29 -04:00
Jrc13245 1ec1c79fd9 fix duplicate buff notifications 2026-03-21 21:37:38 -04:00
Jrc13245 0ba5bd0ebd fix some incoming damage mistaken as outgoing, make sure all damage text has a color for its damage type 2026-03-21 14:44:23 -04:00
DCV-2142 790d96d9e0 Fixed incoming heals not showing healer's name 2026-03-09 17:11:16 +02:00
Jrc13245 7d3b9ba1b8 fix pet damage 2026-02-14 10:48:44 -05:00
Jrc13245 33b8b58255 fix old errors and improve efficiency and resource usage 2026-02-13 16:27:29 -05:00
Jrc13245 684bc9190e fix playerguid race condition 2026-02-11 17:47:12 -05:00
Jrc13245 f8d213d89a updates to fix for users not seeing anything in their incoming and outgoing 2026-02-11 17:22:54 -05:00
Jrc13245 df2bafb8a6 fix outgoing damage bug and improve performance 2026-02-11 16:51:07 -05:00
Jrc13245 53d82a0ad1 dll updates 2026-02-10 15:56:04 -05:00
LaYt 52f87d3af8 update 2025-08-05 15:29:59 -04:00
AtheneGenesis e0ca01eff3 Update MikCombatEventHelper.lua 2018-11-15 22:45:05 +01:00
toinetoine 4469495dbc fixes for lua errors in the chinese client (combat text different from what's expected (which is what the english client prints) 2018-11-14 23:36:36 +08:00
toinetoine 1f45c28601 Fixes for Chinese Client: Added font option that displays CN characters correctly (for aura names, etc.) and fixed edge case where non-critical heal on others shows incorrect amount on the cinese client. 2018-10-05 02:01:07 +08:00
Athene 65afc20870 Pet elemental spell school fix 2016-01-09 16:42:31 +01:00
Athene 8b83ccf60b Pets elemental attacks fix 2016-01-09 13:19:19 +01:00
Athene 63e5606597 DoT icon fix (US client) 2015-11-07 00:42:53 +01:00
Athene 8a6421355b Pet income Hotfix 2015-10-17 23:13:33 +02:00
Athene 4093373147 Patch 4.3
The pet update
2015-10-17 22:02:24 +02:00
Athene a613ef0a3a 4.2 - lightweight
cleaned unnecessary stuff
2015-10-17 21:56:14 +02:00
Athene 848f118c22 Heal over Time Fix 2015-09-04 00:00:17 +02:00
Athene ce4fa23fcb Patch 4.0
Patch 4.0
2015-07-03 00:20:07 +02:00
Athene 8ea51a94d0 Patch 3.9 2015-05-29 23:33:04 +02:00
Athene 73212ebe33 Initial Release
Clean MSBT 3.01 from Mik's
2015-05-29 23:25:35 +02:00