Commit Graph
38 Commits
Author SHA1 Message Date
Brues 0229b07122 removed Babble 2026-06-23 14:28:20 -05:00
Brues 9f88f0bf32 Replace FindBuff tooltip scanning with C_UnitAuras/C_Item
GetAuraIcon resolves buff/debuff icons via C_UnitAuras.GetAuraDataBySpellName (returns the icon directly, no UnitBuff/UnitDebuff follow-up) and temporary weapon-enchant icons via C_Item.GetWeaponEnchantInfo + C_Item.GetEnchantInfo + C_Spell.GetSpellTexture. This drops ~48 tooltip create/scan/hide ops per uncached effect and, unlike the old FindBuff, actually yields an icon for weapon-enchant-named effects. The dead tracking-spell branch is removed, the AddAnimation call site no longer dead-ends on non-matches (falls through to the spellId/Babble/item resolvers), and the now-unused MSBT_Tooltip frame is removed from the XML.
2026-06-23 02:10:07 -05:00
Brues 9d0f945c59 Make FindItemIcon return the icon consistently from both paths
The equipped-slot path returned (slot, nil, icon, count) while the bag path returned just the icon. The sole caller (AddAnimation) uses only the first return value as the texture, so equipped items produced a slot number instead of an icon path. Both paths now return the icon as the first value. Also call FindItemIcon once in the caller instead of three times, folding the no-icon case into the same branch.
2026-06-22 19:15:30 -05:00
Brues 8c35b8b6ad Fix equipped-item match in FindItemIcon and drop the link loop
The equipped-slot check compared itemName to its own lowercase (always matching the first named slot) instead of the searched item; now it compares against item. The separate GetInventoryItemLink/ItemLinkToName loop for slots past INVSLOT_LAST_EQUIPPED is folded into the ItemLocation loop by extending its range by 4.
2026-06-22 19:09:27 -05:00
Brues e8b3b81241 Remove SuperWoW and UnitXP SP3 integration
Drops the SuperWoW and UnitXP SP3 detection flags and all their code paths. GUID/unit-name resolution (GetNameFromGUID, IsPetGUID, EnsurePlayerGUID, player GUID caching) now relies solely on Nampower APIs; the spellId icon fast path keeps only its Nampower branch; and GetUnitIDFromName falls back to the raw-combat-logging path and name cache. UnitXP was detection-only and never read. README updated to reflect the removal.
2026-06-22 18:12:51 -05:00
Brues bf5be40e78 Use C_Spell/C_Item APIs for spell name and item icon lookups
GetSpellNameFromId now calls C_Spell.GetSpellName instead of the SuperWoW/Nampower pcall chain. FindItemIcon iterates equipped slots and bags via ItemLocation and C_Item.GetItemName/GetItemIcon. AddAnimation hoists strlower(name) into a local lowerName to avoid repeated calls and feeds the lowercased name to FindItemIcon.
2026-06-22 18:00:24 -05:00
Brues 6a9dd18ce0 Use CreateColor for damage type text coloring
Replace the manual {r,g,b} table and hex color-prefix strings with CreateColor-based color objects. GetDamageTypeFontColor now builds each school color via a CreateSpellColor helper that also caches a colorStr markup string, adds a Holy color, and retunes the existing school colors. FormatEventText and AddAnimation consume the new objects (color.colorStr and dtColor:GetRGB()), and the dead GetDamageTypeColor lookup is removed.
2026-06-22 18:00:04 -05:00
Arizonacan723 2039d46d9e Merge remote-tracking branch 'upstream/master' 2026-04-06 16:33:27 -07:00
Jrc13245 c6e246c134 fixes 2026-04-06 13:50:29 -04:00
Jrc13245 cf233d2e6a fix errors: 2026-03-21 17:43:43 -04:00
Jrc13245 0ba5bd0ebd fix some incoming damage mistaken as outgoing, make sure all damage text has a color for its damage type 2026-03-21 14:44:23 -04:00
DCV-2142 882bcb3783 Merge branch 'master' of https://github.com/DCV-2142/Vanilla_MikScrollingBattleText 2026-03-13 02:11:55 +02:00
DCV-2142 140feda4a0 Fixed incorrect nampower icons for 2 spells
Flametongue attack + Stratholme Holy Water
2026-03-13 02:11:35 +02:00
Jrc13245 4b236e8446 fix evade event handling 2026-03-12 19:25:33 -04:00
Jrc13245 33b8b58255 fix old errors and improve efficiency and resource usage 2026-02-13 16:27:29 -05:00
Jrc13245 f2065abcfc change spell dmg color by type outgoing only 2026-02-11 18:25:01 -05:00
Jrc13245 684bc9190e fix playerguid race condition 2026-02-11 17:47:12 -05:00
Jrc13245 df2bafb8a6 fix outgoing damage bug and improve performance 2026-02-11 16:51:07 -05:00
Jrc13245 53d82a0ad1 dll updates 2026-02-10 15:56:04 -05:00
LaYt 52f87d3af8 update 2025-08-05 15:29:59 -04:00
pepopo978 b7e3415d16 Update MikScrollingBattleText.lua
fix event merging for spell damage procs
2024-01-22 11:14:52 -08:00
pepopo978 e9228327c5 add resist sound 2023-12-12 23:20:15 -08:00
Schaka ed486f29ab fix FontSize scaling on 4k displays 2023-10-31 12:31:41 +01:00
Athene da3c3d8e19 Added stance requirement for every triggers 2016-01-22 18:09:51 +01:00
Athene 04feb08800 Profile hotfix 2015-11-30 21:41:18 +01:00
Athene 04eccd916e fix <4.4 to 4.4 2015-11-30 18:18:45 +01:00
Athene 00517d96ef Patch 4.4
game damage font
6 new fonts
2015-11-27 17:04:36 +01:00
Athene 63e5606597 DoT icon fix (US client) 2015-11-07 00:42:53 +01:00
Athene 8a6421355b Pet income Hotfix 2015-10-17 23:13:33 +02:00
Athene 4093373147 Patch 4.3
The pet update
2015-10-17 22:02:24 +02:00
Athene a613ef0a3a 4.2 - lightweight
cleaned unnecessary stuff
2015-10-17 21:56:14 +02:00
Athene 3ed3ff0e18 Melee abilities color fix 2015-10-11 13:35:58 +02:00
Athene bfabfe85f2 Hand of Justice Fix
Remove HoJ from the saved triggers
2015-08-27 15:17:14 +02:00
Athene b52eff8ae7 Patch 4.1
localization fix
windfury trigger fix
2015-08-27 14:53:04 +02:00
Athene deecc4d968 CreationVersion fix 2015-07-22 23:09:19 +02:00
Athene ce4fa23fcb Patch 4.0
Patch 4.0
2015-07-03 00:20:07 +02:00
Athene 8ea51a94d0 Patch 3.9 2015-05-29 23:33:04 +02:00
Athene 73212ebe33 Initial Release
Clean MSBT 3.01 from Mik's
2015-05-29 23:25:35 +02:00