Add newitem module: highlight freshly-acquired bag items

New module built on ClassicAPI's C_NewItems + BAG_NEW_ITEMS_UPDATED. Glows bag slots (bags 0-4) holding items acquired since login, keyed on item GUID so the flag survives rearranging. Hovering an item acknowledges it (RemoveNewItem); closing the bags clears the rest via ClearAll. Glow is UI-ActionButton-Border, sized off the slot width so it tracks the icon_size config. To stay decoupled from the bag frames, the bag module now broadcasts a reusable "bag:closed" event through pfUI.events from its OnHide (carrying the container so subscribers can tell backpack from bank), guarded so the initial setup Hide() doesn't fire a phantom close. Config: appearance.bags.newitem + newitem_color, with GUI toggles.
2026-10-09 07:00:00 +00:00 · 2026-07-17 14:47:22 -05:00
parent 31ff2773b3
commit bd4a40b0f2
7 changed files with 76 additions and 1 deletions
@@ -0,0 +1,63 @@
+pfUI:RegisterModule("newitem", function ()
+  if not pfUI.bag then return end
+  if C.appearance.bags.newitem ~= "1" then return end
+
+  pfUI.newitem = {}
+
+  local color = CreateColor(strsplit(",", C.appearance.bags.newitem_color))
+
+  function pfUI.newitem:UpdateSlot(bag, slot)
+    if bag < 0 or bag > 4 then return end
+    if not pfUI.bags[bag] then return end
+    if not pfUI.bags[bag].slots[slot] then return end
+
+    local frame = pfUI.bags[bag].slots[slot].frame
+
+    if not frame.newitem then
+      local glow = frame:CreateTexture(nil, "OVERLAY")
+      glow:SetTexture("Interface\\Buttons\\UI-ActionButton-Border")
+      glow:SetBlendMode("ADD")
+      glow:SetVertexColor(color:GetRGBA())
+      glow:SetPoint("CENTER", frame, "CENTER")
+      glow:Hide()
+      frame.newitem = glow
+
+      frame:HookScript("OnEnter", function()
+        C_NewItems.RemoveNewItem(bag, slot)
+      end)
+    end
+
+    local w = frame:GetWidth()
+    if w > 0 then frame.newitem:SetSize(w * 1.8, w * 1.8) end
+
+    frame.newitem:SetShown(frame.hasItem and C_NewItems.IsNewItem(bag, slot))
+  end
+
+  -- The new-item set can change without any slot's contents changing (an item
+  -- acknowledged, pruned when it leaves the bags, or ClearAll) -- re-evaluate
+  -- every decorated slot when that happens.
+  function pfUI.newitem:RefreshAll()
+    for bag in pairs(pfUI.bags) do
+      local slots = pfUI.bags[bag] and pfUI.bags[bag].slots
+      if slots then
+        for slot in pairs(slots) do
+          pfUI.newitem:UpdateSlot(bag, slot)
+        end
+      end
+    end
+  end
+
+  -- per-slot: pfUI re-runs UpdateSlot whenever a slot's contents change.
+  hooksecurefunc(pfUI.bag, "UpdateSlot", function(self, bag, slot)
+    pfUI.newitem:UpdateSlot(bag, slot)
+  end)
+
+  EventRegistry:RegisterFrameEventAndCallback("BAG_NEW_ITEMS_UPDATED", function()
+    pfUI.newitem:RefreshAll()
+  end)
+
+  pfUI.events:RegisterCallback("bag:closed", function(_, object)
+    if object then return end
+    C_NewItems.ClearAll()
+  end, "newitem")
+end)