grom/benilla-octo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comments in the UI XML and the Lua fork's manifest: no dead marker, no record number (#300)

Browse Source 
Fixes #31. The last comments outside the Rust sources that carried a dead name or a private record number:

- `OptionsFrame.xml` and `SpellBookAdapters.xml` drop the `BENILLA_ALLOW_OWN_UI=1` marker, which no code or test reads.
- `third_party/lua-src/Cargo.toml` says why the fork exists without its record number, in plain case.

Comment text only: every file is identical with its comments stripped. The Rust test comments #31 also listed were rewritten with their crates' comment passes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Sam Sung
2026-09-25 17:09:35 +07:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 9c32e5126e
commit 05ab92ce73
3 changed files with 13 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/benilla-app/assets/ui/OptionsFrame.xml
+1 -1
View File
@@ -3166,7 +3166,7 @@
GameMenuFrame.xml wraps ToggleGameMenu, IsOptionFrameOpen and UpdateMicroButtons, which
name only the stock three. Chat-tab hover (FloatingChatFrame.lua l.842/860) reads the
hidden UIOptionsFrame, so it works while this window, which does not cover the chat, is
open. BENILLA_ALLOW_OWN_UI=1 -->
open. -->
<Script><![CDATA[
-- This window's UIPanelWindows row, the reference's OptionsFrame values (UIParent.lua:16):
-- the centre slot, openable while dead. UIParent.xml, which makes the table, loads first.
crates/benilla-app/assets/ui/SpellBookAdapters.xml
+1 -1
View File
@@ -1,6 +1,6 @@
<Ui>
<!--
BENILLA_ALLOW_OWN_UI=1. Deviation: over the unedited stock SpellBookFrame.xml, the pet
Deviation: over the unedited stock SpellBookFrame.xml, the pet
page's autocast widgets take the pet bar button's proportions.
The `$parentAutoCast` shine (UI-AutoCastButton.mdx) is squared on the button, 37x37 at
CENTER (0,0) and scale 1.48, so its rim runs on the viewport edge at the pet button's
third_party/lua-src/Cargo.toml
Vendored
+11 -15
View File
@@ -1,23 +1,19 @@
# A fork of the `lua-src` crate (MIT, github.com/mlua-rs/lua-src-rs), pinned to the version mlua
# 0.11 asks for, carrying ONE deliberate change to the Lua 5.1.5 sources it compiles.
# 0.11 asks for, carrying one deliberate change to the Lua 5.1.5 sources it compiles.
#
# WHY THIS EXISTS — decision 1215. The 1.12 addon corpus is written for Lua 5.0 and uses the
# iterator-less generic-for (`for k, v in someTable do`) in 183 of 218 addons. Lua 5.1 deleted the
# opcode that made it work, so on stock 5.1 it raises `attempt to call a table value` — the first
# error for 60 of 218 addons at session start, three quarters of everything that breaks in a running
# session. It is not reachable from inside Lua: not a library function, not a global, an OPCODE.
# Why it exists: the 1.12 addon corpus is written for Lua 5.0 and uses the iterator-less
# generic-for (`for k, v in someTable do`) in 183 of 218 addons. Lua 5.1 deleted the opcode that
# made it work, so on stock 5.1 it raises `attempt to call a table value`, the first error for 60 of
# 218 addons. No Lua-side shim can restore an opcode. The fork stays on 5.1.5 and restores that one
# opcode's 5.0 behaviour, which Lua shipped as "for compatibility only", so every other 5.1 fix and
# mlua's whole surface stay intact.
#
# WHAT IS AND IS NOT CHANGED: `BENILLA.md` lists every hunk against upstream's `lua-5.1.5/` tree
# What changes: `BENILLA.md` lists every hunk against upstream's `lua-5.1.5/` tree
# (eight, in three files) and the one command that verifies the sources against the registry copy.
#
# When the payload does land we are still NOT adopting Lua 5.0: we stay on 5.1.5 and restore the
# behaviour of one opcode Lua itself shipped and labelled "for compatibility only", so every other
# 5.1 fix and mlua's whole surface stay intact.
#
# The crate's own `src/lib.rs` is upstream's, with Lua 5.2/5.3/5.4/5.5 stripped from the `Version`
# enum and the trees deleted. That is deliberate rather than tidiness: benilla builds 5.1 and only
# 5.1, and a fork that still *offers* the other four would answer a request for them with a missing
# directory at build time instead of a compile error here.
# The crate's own `src/lib.rs` is upstream's, with Lua 5.2 to 5.5 stripped from the `Version` enum
# and their trees deleted, so asking for another version is a compile error here rather than a
# missing directory at build time.
[package]
name = "lua-src"
version = "550.0.0"