grom/benilla-octo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

comments: the XP-gain reader says why dropping the group bonus is safe

Browse Source 
vmangos always sends 1.0, meaning none (Player.cpp:3039), so 1.12
shows no group-bonus line against it either.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Sam
2026-09-23 20:26:52 +07:00
co-authored by Claude Opus 5.5
parent fadcf4d6b4
commit d0846e2516
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/benilla-protocol/src/messages/progression.rs
+2 -1
View File
@@ -16,7 +16,8 @@ pub struct XpGain {
}
/// Read `SMSG_LOG_XPGAIN`: `u64 victim, u32 total, u8 type` (0 kill, 1 other), then for a kill
/// `u32 base, f32 groupBonus`. Deviation: the group bonus is read and dropped.
/// `u32 base, f32 groupBonus`. Deviation: the group bonus is read and dropped; vmangos always
/// sends 1.0, meaning none (`Player.cpp:3039`), so 1.12 shows no group-bonus line either.
pub(super) fn read_xp_gain(r: &mut impl Read) -> io::Result<XpGain> {
let victim = read_u64_le(r)?;
let total = read_u32_le(r)?;