brues/SuperCleveRoidMacros
1
1
Fork 0
mirror of https://github.com/brues-code/SuperCleveRoidMacros.git synced 2026-09-16 03:38:00 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity
482 Commits 2 Branches 14 Tags
11e33fc0d33881c89e4e80ebce00a925f258b996
Commit Graph
43 Commits
Author SHA1 Message Date
Jrc13245 6ab3f7a157 fix debuff bug, reformat pfui hooks, add rangedclip and norangedclip conditionals 2026-03-13 08:25:23 -04:00
Jrc13245 efdcde3eca performance updates, meleerange conditional checks if unit is alive 2026-03-11 19:57:33 -04:00
Jrc13245 9c05a6fc6a fix pfui loading objects without superwow 2026-03-03 11:10:55 -05:00
Jrc13245 b56beef4b2 remove more superwow only functions 2026-03-02 09:01:34 -05:00
Jrc13245 2f0f000733 no superwow required, update for nampower 3 2026-03-01 09:33:41 -05:00
Jrc13245 37afbd047c update pfui compatibility 2026-02-16 21:32:37 -05:00
Jrc13245 c2c8af7d2d pfui 7_6 update compatibility and reformat readme 2026-02-08 17:42:16 -05:00
Jrc13245 fcd68c6efb update for pfui 7_6 updates 2026-02-04 17:36:17 -05:00
Jrc13245 ee2de33001 update nampower support to 2_27_2 and pfUI 7_6+ 2026-02-04 16:23:34 -05:00
Jrc13245 469aaa00b1 ultimamacros compatibility supporrt 2026-02-01 00:32:20 -05:00
Jrc13245 174c636673 fix macro icons, enhance libdebuff further with nampower, code cleanup, improve compatibility with supermacro 2026-01-31 15:02:03 -05:00
Jrc13245 ede836f1b8 fix castsequence and fix possible 132 logout error caused by dlls 2026-01-30 19:19:54 -05:00
Jrc13245 cbbc4cc5a7 make supermacro compatibility work with new slashcommands 2026-01-22 17:46:03 -05:00
Jrc13245 8f1e2166b1 fix false immunities 2026-01-16 09:35:29 -05:00
Jrc13245 612873260d add gcd conditional and firstaction slashcommand and fix stopmacro 2026-01-15 16:16:49 -05:00
Jrc13245 649586c552 fix stopmacro and implement skipmacro 2026-01-15 14:50:55 -05:00
Jrc13245 c230b1decb fix stopmacro and fix mouseover in other addons 2026-01-15 11:48:01 -05:00
Jrc13245 b942cdb07e update for pfui compatibility 2026-01-10 11:59:46 -05:00
Jrc13245 8d39ae75c2 add error catcher and fix libdebuff accesses 2025-12-26 16:42:58 -05:00
Jrc13245 3d58928155 fix supermacros extended macros being cleared by cleveroids hooks 2025-12-21 09:32:49 -05:00
Jrc13245 8a97fa849c fix stopmacro usability broken due to removal of nampower handling 2025-12-15 08:34:57 -05:00
Jrc13245 1c76c12ff1 remove addon-level nampower spell queuing 2025-12-15 07:31:36 -05:00
Jrc13245 9f5a379a3b fix stopmacro affecting non cast lines 2025-12-13 19:38:54 -05:00
Jrc13245 aa2a054df9 fix stopmacro for spell queuing and range fix for channeled spells 2025-12-12 21:36:25 -05:00
Jrc13245 2fd4ac3298 reduce bag event usage for lag and fix macro calling within macros 2025-12-12 15:43:21 -05:00
Jrc13245 fdaa2a108c twthreat conditional integration, ttk conditional integration, quickheal conditional integration 2025-12-05 22:38:43 -05:00
Jrc13245 86fa4476f6 fix equip with conditionals and dont pollute runmacro global namespace 2025-12-05 18:26:33 -05:00
Jrc13245 ce017f5832 fix lower rank spells showing as refreshing higher ranks in pfui. further improve debuff duration handling. 2025-11-30 19:25:19 -05:00
Jrc13245 ff6ec25c06 bleed immunity, fix icons and their tooltips with no available actions, reformat readme 2025-11-27 09:21:41 -05:00
Jrc13245 6a4f7a417c fix revenge reactive and majorly improve pfui compatibility for icons and actionbars 2025-11-26 07:48:12 -05:00
Jrc13245 f6df0b2b5a fix icon issue and fix carnage talent duration refreshers updating visually for pfui 2025-11-19 17:50:30 -05:00
Jrc13245andClaude c5a57af024 Fix combo point tracking and queue glow for instant finishers 
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-17 20:28:22 -05:00
Claude ce8f1dcf7d Fix pfUI AddEffect handling multiple calls 
Don't clear the confirmed flag after first use since pfUI may call
AddEffect multiple times for the same spell. Instead, rely on the
time-based expiry (0.5s timeout) to prevent stale tracking data.

This fixes the issue where the second AddEffect call would see
unconfirmed tracking and ignore the correct duration.
 2025-11-16 22:46:17 +00:00
Claude aedb2684b5 Add confirmation system to prevent pfUI from using evaluation-only tracking 
Problem: Macro conditional evaluations create tracking entries, but
pfUI's AddEffect can fire during these evaluations (before actual cast),
causing it to use incorrect combo point data.

Flow before fix:
1. Macro evaluates [combo:>0] → TrackComboPointCast(0 CP, confirmed=false)
2. Macro evaluates again → TrackComboPointCast(1 CP, confirmed=false)
3. pfUI AddEffect fires → uses tracking (wrong timing!) ✗
4. SPELLCAST_START fires (actual cast)

Flow after fix:
1. Macro evaluates [combo:>0] → TrackComboPointCast(0 CP, confirmed=false)
2. Macro evaluates again → TrackComboPointCast(1 CP, confirmed=false)
3. SPELLCAST_START fires → sets confirmed=true ✓
4. pfUI AddEffect fires → only uses tracking if confirmed=true ✓

Changes:
- Added 'confirmed' field to tracking (default: false)
- SPELLCAST_START sets confirmed=true when spell actually casts
- pfUI AddEffect hook only uses tracking if confirmed=true
- Clear confirmed flag after use to prevent reuse
- Clear on failed/interrupted casts

Debug shows: "Ignoring X tracking (not confirmed - evaluation only)"
when preventing use of evaluation-only data.
 2025-11-16 18:51:57 +00:00
Claude c9bd224c2b Fix pfUI AddEffect timing - use name-based tracking instead of ID 
CRITICAL TIMING FIX: pfUI's AddEffect fires BEFORE UNIT_CASTEVENT!

Event sequence:
1. CastSpell → Extension hooks → name-based tracking stores 5 CP, 18s ✓
2. pfUI AddPending → GetDuration (base 10s)
3. SPELLCAST_STOP → pfUI AddEffect fires
4. Our AddEffect hook fires (ID tracking doesn't exist yet!) ✗
5. UNIT_CASTEVENT → ID-based tracking created ✓

Solution: Use name-based tracking (available at step 4) instead of
ID-based tracking (not created until step 5).

Changed pfUI AddEffect hook to:
- Use CleveRoids.ComboPointTracking[effect] (name-based)
- Check cast_time < 0.5s to ensure freshness
- This data exists when pfUI calls AddEffect

Now shows: "[pfUI AddEffect Hook] Overriding Rip duration to 18s"
Instead of: "[pfUI AddEffect Hook] Overriding Rip duration to 10s"
 2025-11-16 18:41:39 +00:00
Claude 3e669a7b7a Fix pfUI integration - use unit names and spell names, not GUIDs/IDs 
CRITICAL FIX: pfUI's libdebuff uses completely different data structures:
- Uses unit NAME (not GUID)
- Uses unit LEVEL as a key
- Uses spell NAME (effect, not ID)
- Storage: pflib.objects[unitName][unitLevel][effectName]

Fixed SyncComboDurationToPfUI:
- Convert GUID to unit name (check target, fallback to guidToName map)
- Get unit level from target or default to 0
- Convert spell ID to spell name using SpellInfo()
- Remove rank from spell name to match pfUI's format
- Search both specific level and level 0 (pfUI's fallback)

Fixed AddEffect hook:
- Updated parameters to match pfUI signature: (unit, unitlevel, effect, duration, caster)
- Check spell by name instead of ID
- Map spell name back to ID to find tracking data

This ensures pfUI's cooldown displays show correct combo durations.
 2025-11-16 18:20:51 +00:00
Claude d6b4ae3d97 Add direct pfUI duration synchronization for combo spells 
After analyzing pfUI's cooldown module, we need to directly sync
combo durations to pfUI's libdebuff.objects storage:

- Added SyncComboDurationToPfUI function to force-update pfUI's
  stored debuff duration after tracking combo spells
- Called from UNIT_CASTEVENT handler after AddEffect
- This ensures pfUI's cooldown display shows the correct combo
  duration (e.g., 28s for 5 CP Rip) instead of base 12s

pfUI's cooldown module is just a display layer - it shows durations
from pfUI.api.libdebuff.objects. By directly updating this storage,
we ensure the correct duration is displayed regardless of timing.
 2025-11-16 18:18:41 +00:00
Claude 60bf1741ed Add pfUI cooldown integration for combo-aware durations 
Hook into pfUI.api.libdebuff to inject combo-based durations:
- Hook GetDuration: Returns learned combo durations for combo spells
- Hook AddEffect: Injects tracked combo durations when debuffs are applied

This ensures pfUI's cooldown module displays the correct duration
(e.g., 28s for 5 CP Rip instead of base 12s).

Debug messages show when pfUI hooks are triggered in debug mode.
 2025-11-16 18:15:33 +00:00
Jrc13245 c65642a129 fix compatibility with pfui macrotweak 2025-11-12 16:33:54 -05:00
Jrc13245 2da28c2653 increase supermacro support 2025-08-28 16:19:51 -04:00
Jrc13245 a7c979b5db fix castsequence compatibility with supermacro 2025-08-27 14:27:17 -04:00
Jrc13245 3ee68a3e84 cleveroids syntax now works inside supermacro super tab macros 2025-08-26 16:25:56 -04:00
Jrc13245 fb359993b2 Initial Commit 2025-08-18 16:15:25 -04:00