enhanced_water.wgsl keeps the water lane's row view of the shared light buffer (fixes the WGSL
composer failure); the p0 fog hook reads the MonkeyFrame block through water_monkey() (row 533).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
enhanced_water.wgsl keeps the water lane's row view of the shared light buffer (fixes the WGSL
composer failure); the p0 fog hook reads the MonkeyFrame block through water_monkey() (row 533).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README now leads with the whole game being playable, keeps the two open fronts (the long
tail, and addons, options and performance), drops the downloads goal, and sends packaged builds
and server changes to forks, with GitHub's fork list linked.
Corrected against the code:
- A server that requires Warden is refused at the handshake (benilla-protocol
world/session.rs), so the README asks for Warden off; vmangos ships with it off
(mangosd.conf.dist.in, Warden.WinEnabled and Warden.OSXEnabled default to 0).
- `cargo run` builds the default `dev` feature, which keeps benilla-config/ at the repo root
(benilla-app local_state.rs), so the addon folder is named there, not beside the binary.
- The named addons are the ones whose fixes landed: Questie (3e92b4f0), pfUI (0a3c0692),
Bagnon (321bcbb3) and Bartender2 (a753a8b5).
- assets/ui holds adapters and the options, game menu, key bindings and script log windows
benilla draws itself; the options window and the ESC menu follow the Classic Era client.
- The client reports enUS and reads the enUS DBC columns, so the install asked for is English.
Kept after checking: no third-party WoW crates in any manifest; on Linux, Wayland and X11 load
at run time, so ALSA, udev and pkg-config are the whole build-time list; localhost:3724 is the
default; WOW_USER and WOW_PASS log in from a plain clone. Every link resolves.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The README now leads with the whole game being playable, keeps the two open fronts (the long
tail, and addons, options and performance), drops the downloads goal, and sends packaged builds
and server changes to forks, with GitHub's fork list linked.
Corrected against the code:
- A server that requires Warden is refused at the handshake (benilla-protocol
world/session.rs), so the README asks for Warden off; vmangos ships with it off
(mangosd.conf.dist.in, Warden.WinEnabled and Warden.OSXEnabled default to 0).
- `cargo run` builds the default `dev` feature, which keeps benilla-config/ at the repo root
(benilla-app local_state.rs), so the addon folder is named there, not beside the binary.
- The named addons are the ones whose fixes landed: Questie (3e92b4f0), pfUI (0a3c0692),
Bagnon (321bcbb3) and Bartender2 (a753a8b5).
- assets/ui holds adapters and the options, game menu, key bindings and script log windows
benilla draws itself; the options window and the ESC menu follow the Classic Era client.
- The client reports enUS and reads the enUS DBC columns, so the install asked for is English.
Kept after checking: no third-party WoW crates in any manifest; on Linux, Wayland and X11 load
at run time, so ALSA, udev and pkg-config are the whole build-time list; localhost:3724 is the
default; WOW_USER and WOW_PASS log in from a plain clone. Every link resolves.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
CameraSkybox becomes a weighted layer list (ghost > WMO > zone, modern
crossfade), flags 0x1 day cycle / 0x2 keep celestial / 0x4 fog cone, the
celestial model as a second layer, and a CPU rig + mat-anim rows so skybox
bones, texture transforms, colour and alpha tracks play.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CameraSkybox becomes a weighted layer list (ghost > WMO > zone, modern
crossfade), flags 0x1 day cycle / 0x2 keep celestial / 0x4 fog cone, the
celestial model as a second layer, and a CPU rig + mat-anim rows so skybox
bones, texture transforms, colour and alpha tracks play.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reads the 1.12 two-field and the extended ID/Name/Flags/CelestialName table by
header field count; zone_skyboxes() runs the modern collector over the
sphere-weighted Light walk.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reads the 1.12 two-field and the extended ID/Name/Flags/CelestialName table by
header field count; zone_skyboxes() runs the modern collector over the
sphere-weighted Light walk.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of #41: the first of five `benilla-app` pieces. This one is the UI script layer: `ui_script` with its test harnesses, the text engine and layout (`ui_text`), the UI pass and the UI model panes. Its comments are rewritten to the rule in `docs/METHOD.md`, which is what the code does and the reference fact behind it, in a line. 22,041 comment lines become 7,133.
- **The mechanical strip.** The citations that were only a private record number go first, and each edit is shown to be a pure removal.
- **Wrong facts corrected.** The rewrite corrects the comments that stated wrong facts. Among them:
- On a fresh login the reference fires `PLAYER_LOGIN` and `PLAYER_ENTERING_WORLD` from the player's create (`0x5deb60` → `0x4908c0`); only a `/reload` goes through `0x490168`. The comments now state both paths.
- `ComputeStep` (`0x5ca2d0`) applies negative pair kerns and rounds up. It does have a kerning term.
- A fallback icon global and the retired `UiPanels.xml` panels no longer exist. The comments that named them now describe the stock FrameXML mechanism that replaced them.
- Stock FrameXML line citations are checked against the stock 1.12 files and corrected, and several misattributed files are fixed (`MainMenuBarArtFrame` lives in `MainMenuBar.xml`).
- Dozens more turned up on the way: docs sitting on the wrong item, removed functions, stale counts and links.
- **Deviation labels.** "Deviation:" now marks only a choice with a reason. An unbuilt behaviour says so plainly.
- **Verification.** Every file strips to identical code, and `cargo fmt --check` is clean. Five second readers compared every file old against new, restored the facts the rewrite had dropped, and checked each new citation against the code, the stock files, vmangos and the reference.
Behaviour differences the rewrite surfaced are filed as their own issues (#183 among them). The comments here state what the code does. String literals are untouched; they are #92.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Part of #41: the first of five `benilla-app` pieces. This one is the UI script layer: `ui_script` with its test harnesses, the text engine and layout (`ui_text`), the UI pass and the UI model panes. Its comments are rewritten to the rule in `docs/METHOD.md`, which is what the code does and the reference fact behind it, in a line. 22,041 comment lines become 7,133.
- **The mechanical strip.** The citations that were only a private record number go first, and each edit is shown to be a pure removal.
- **Wrong facts corrected.** The rewrite corrects the comments that stated wrong facts. Among them:
- On a fresh login the reference fires `PLAYER_LOGIN` and `PLAYER_ENTERING_WORLD` from the player's create (`0x5deb60` → `0x4908c0`); only a `/reload` goes through `0x490168`. The comments now state both paths.
- `ComputeStep` (`0x5ca2d0`) applies negative pair kerns and rounds up. It does have a kerning term.
- A fallback icon global and the retired `UiPanels.xml` panels no longer exist. The comments that named them now describe the stock FrameXML mechanism that replaced them.
- Stock FrameXML line citations are checked against the stock 1.12 files and corrected, and several misattributed files are fixed (`MainMenuBarArtFrame` lives in `MainMenuBar.xml`).
- Dozens more turned up on the way: docs sitting on the wrong item, removed functions, stale counts and links.
- **Deviation labels.** "Deviation:" now marks only a choice with a reason. An unbuilt behaviour says so plainly.
- **Verification.** Every file strips to identical code, and `cargo fmt --check` is clean. Five second readers compared every file old against new, restored the facts the rewrite had dropped, and checked each new citation against the code, the stock files, vmangos and the reference.
Behaviour differences the rewrite surfaced are filed as their own issues (#183 among them). The comments here state what the code does. String literals are untouched; they are #92.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
