Commit Graph
96 Commits
Author SHA1 Message Date
Claude 3d6f03336c Fix combo tracking commands - remove load-time existence checks
The combotrack/comboclear commands were checking if functions existed at
file load time, but ComboPointTracker.lua loads after Core.lua, so the
checks always failed. Removed the checks since by runtime (when the user
executes the command) all files will be loaded and functions will exist.

Fixes "Combo point tracking not available" message.
2025-11-16 15:44:24 +00:00
Claude 4cf8e07a17 Improve combo point duration tracking system
Major enhancements to the combo point finisher tracking system:

**ComboPointTracker.lua:**
- Added spell ID-based tracking (ComboScalingSpellsByID table)
- All Rupture ranks (1943, 8639, 8640, 11273, 11274, 11275): 8s + 2s per CP
- Kidney Shot ranks (408, 8643): Rank 1: 1s + 1s per CP, Rank 2: 2s + 1s per CP
- Druid Rip ranks (1079, 9492, 9493, 9752, 9894, 9896): 12s + 4s per CP (corrected from 10s + 2s)
- New TrackComboPointCastByID() function for UNIT_CASTEVENT integration
- Initialize spell_tracking table to prevent nil errors
- Consistent debug output using CleveRoids.debug flag

**Utility.lua (libdebuff integration):**
- UNIT_CASTEVENT handler now checks combo scaling spells first
- Calls TrackComboPointCastByID() before normal duration lookup
- Learning system skips combo spells (they're dynamically calculated)
- Improved debug messages distinguish combo spells from regular spells

**Core.lua (console commands):**
- Added /cleveroid combotrack - Display recent combo finisher casts
- Added /cleveroid comboclear - Clear combo tracking data
- Updated help text with combo point tracking section

**README.md:**
- New "Combo Point Scaling" section with examples
- Updated settings documentation with new commands
- Added /cleveroid debug to settings list
- Example macros showing combo point-aware debuff conditionals

This system ensures accurate duration tracking for:
- Rogue: Rupture (8-16s), Kidney Shot (1-6s)
- Druid: Rip (12-28s)

All durations are now calculated based on actual combo points used at cast time.
2025-11-16 15:31:38 +00:00
Torio 4d288cd482 Merge pull request #23 from jrc13245/main
merge
2025-11-16 10:23:13 -05:00
Jrc13245 edfb44edd7 another fix 2025-11-16 10:03:56 -05:00
Jrc13245 68ea467e1a fix gitignore 2025-11-16 10:02:38 -05:00
Jrc13245 03bfa82d87 update readme 2025-11-16 09:59:59 -05:00
Jrc13245 93c73e8d93 update readme 2025-11-16 09:56:54 -05:00
Jrc13245 1610920dda immunity tracking system 2025-11-16 09:46:51 -05:00
Torio 96e3c9b90e Delete .gitignore 2025-11-16 09:46:37 -05:00
Torio 8449dd3382 Merge pull request #21 from AdmiralFrijoles/main
New conditionals level and mylevel
2025-11-14 07:18:30 -05:00
Jrc13245 122fc0a908 no longer require abilities on actionbar to get icon 2025-11-13 16:40:37 -05:00
Jrc13245 92562ab1a4 Fix macro icons with syntax not using conditionals and fix imbue conditionals 2025-11-13 15:46:00 -05:00
Torio 9431ddcd7a Merge pull request #20 from jrc13245/main
pr
2025-11-12 16:55:41 -05:00
Jrc13245 c65642a129 fix compatibility with pfui macrotweak 2025-11-12 16:33:54 -05:00
Jrc13245 642e58598a fix item macros icons when swapped 2025-11-12 16:19:08 -05:00
Jrc13245 a3b8848449 fix conditionals icons when used with slot numbers 2025-11-11 15:14:06 -05:00
Jrc13245 b9cd6a8802 make buff and debuff validations exact buff names and not string parts 2025-11-11 11:08:37 -05:00
Torio 7b4c530c92 Merge pull request #15 from jrc13245/main
pull request
2025-11-11 07:03:56 -05:00
Jrc13245 1b1d4fe94b revert some changes 2025-11-10 19:59:13 -05:00
Jrc13245 914d9ab916 fix errors ddue to missing comma 2025-11-10 19:45:44 -05:00
Jrc13245 4920675a3a fix errors 2025-11-10 19:38:44 -05:00
Jrc13245 84f5d63be8 fix new conditionals 2025-11-10 19:09:01 -05:00
Jrc13245 b18ad521de readme update 2025-11-10 18:05:23 -05:00
Jrc13245 e088ae4029 new weapon imbue check conditionals 2025-11-10 18:02:59 -05:00
Jrc13245 665b6c52e7 initial combo point duration checker 2025-11-10 17:35:33 -05:00
Jrc13245 4661f0f924 more equip fixes 2025-11-09 13:09:16 -05:00
Jrc13245 1427c4481f fix equip errors 2025-11-09 12:48:56 -05:00
Jrc13245 5845e811b4 update reactive and add usable conditionals 2025-11-08 18:13:24 -05:00
Jrc13245 19be3b70d7 fix equipmh and equipoh errors 2025-11-08 17:53:19 -05:00
Jrc13245 37490c5af6 fix accidentally removed mybuffcount 2025-11-08 17:41:22 -05:00
Jrc13245 c8017c5485 implement UnitXP functions and update nampower and superwow functions 2025-11-08 17:38:35 -05:00
Jrc13245 b43f71df2d gitignore 2025-11-08 11:26:21 -05:00
Jrc13245 af872faa58 update readme add mybuffcount conditional 2025-11-08 11:15:33 -05:00
Jrc13245 ca62efec2a fix cooldown conditional with no argument 2025-11-08 11:11:26 -05:00
Jrc13245 5b416765da fix more equip errors 2025-10-30 14:08:41 -04:00
Jrc13245 a7e6ee88ad fix equip race conditions 2025-10-29 18:59:59 -04:00
Jrc13245 f4aed363b6 update readme 2025-10-29 13:49:31 -04:00
Jrc13245 f5163f7e57 improve target with conditionals functionality 2025-10-29 13:46:42 -04:00
Jrc13245 8fcd17ff53 added ability to track overflow debuffs that show in buff slots on bosses in raids 2025-10-28 19:56:00 -04:00
Jrc13245 8be3d7df3a fix some tooltip errors 2025-10-28 19:43:39 -04:00
Jrc13245 6229cc0f7b update readme with swimming conditional 2025-10-26 14:55:52 -04:00
Jrc13245 c86875849f swimming conditional for druid only 2025-10-26 14:53:42 -04:00
Jrc13245 18f7828c26 fix non-letter or number characters in item or spell names 2025-10-26 12:48:29 -04:00
Jrc13245 6db708f40b fix castsequence reset functionality 2025-10-25 11:34:36 -04:00
Jrc13245 f785990eb5 update readme 2025-10-21 22:26:30 -04:00
Jrc13245 8542a05170 implement standalone debuff timer system 2025-10-21 22:18:10 -04:00
Jrc13245 0f3078d52b fix quotational spells or items used with validatecooldown 2025-10-15 16:33:51 -04:00
Jrc13245 959337f1ff update readme 2025-10-15 16:20:17 -04:00
Jrc13245 80382638cd allow stat conditional to be multi 2025-10-15 16:19:19 -04:00
Jrc13245 4c9c6fff60 new pet conditional 2025-10-08 20:46:03 -04:00