Describe the Issue: Holy Shock is missing 20% healing coefficient.
In Patch 1.18.1 of Turtlecraft, paladins received a new reputation libram from Argent Dawn that was supposed to increase holy shock damage by 20%. However, what ended up happening in reality was that base scaling for holy shock got reduced by 20% due to spaghetti code and the libram now even works with healing when it should not. Amidst the closure news, this bug report was not solved before the server shut down.
It turns out, this bug currently also exists on OctoWoW.
Attached in the first image, I've linked how holy shock used to work before this patch using the leaked 1.17.2 client and setting spellpower to 0 first, then 500 without taking ironclad to provide a baseline scaling for holy shock. As you can see in the picture, the first 2 heals are done with 0 spellpower and the next 3 heals are done with 500 spellpower. This first image proves that originally, holy shock had roughly 40% SP scaling. In the following columns, we do the same test on OctoWoW but find In Octowow, the healing coefficient is bugged and at roughly 20% as we can see in the picture. The fact that in both clients, holy shock heals the same amount at 0 healing, but differently with 500 healing proves this is a healing coefficient issue of the spell.
Attached in the second picture, with the help and generosity of Chronicle, we were able to access Turtlecraft logs before and after 1.18.1 patch where this bug had occurred, to prove my point that this is a leftover bug from 1.18.1. The paladin who was able to holy shock for 3.5k before patch could only do holy shock for 2.6k post patch, and the paladin who was able to holy shock for 2.9k before the patch could only do 2.2k post patch, showing that there was indeed a bug with holy shock scaling in 1.18.1 but it never got addressed before shutdown.
Chronicle has been kind enough to rehost the website so we could check the logs, which I will link the logs down below, but in case the website goes down, the pictures are taken directly from the logs to check holy shock healing.
4 March (Pre-patch) Log for Ellinna/Martikos: https://turtle.chronicleclassic.com/instances/19DJgQ2th3L7et7q
11 March (Pre-patch) Log for Sookie: https://turtle.chronicleclassic.com/instances/zypqHQm52Fg5wExB
15 April (Post-Patch) Log for Ellinna/Martikos: https://turtle.chronicleclassic.com/instances/0qua4ZpsAftm2Sx-
22 April (Post-patch) log for Sookie: https://turtle.chronicleclassic.com/instances/mFai5ABLZzM0obZQ
How to reproduce: Use the leaked 1.7.2 client (or 1.18 if such a thing existed) and use holy shock on yourself in a local server with 500 healing, then do the same on Octowow with 500 healing, you will heal yourself for far less in OctoWoW despite using a higher rank of holy shock. Since Turtle shut down, it's impossible to do the 1.18/1.18.1 comparison other than looking at old logs which I have provided.
How is it supposed to work: Holy shock is missing roughly 20% scaling or total output compared to 1.18. We speculate this is due to addition of Argent Dawn reputation libram but we are not sure. It should have double the healing scaling it currently has. The exact correct calculation is unknown to me as of now, but developers can extract the correct scaling by comparing holy shock in leaked 1.17.2 client to current Octo client by using the same spellpower on both clients. All we can see from the pictures is that Holy shock is missing 20-30% total healing per cast and should be corrected
Character the bug occurred on: Ellinna